Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnmarshalText prioritized for slices #64

Closed
wants to merge 2 commits into from
Closed

UnmarshalText prioritized for slices #64

wants to merge 2 commits into from

Conversation

mayowa
Copy link

@mayowa mayowa commented Jun 5, 2016 •
edited
Loading

I started from #58 and made it work for slices

@kisielk
Copy link
Contributor

kisielk commented Jul 12, 2016

Looks good, but as I commented in #58, it needs tests to verify the functionality.

@kisielk kisielk mentioned this pull request Mar 17, 2017
Closed
@corburn corburn mentioned this pull request Mar 21, 2017
Closed
@Azuka
Copy link
Contributor

Azuka commented Jun 7, 2017

@mayowa, @kisielk, I'd be happy to write tests for this. I urgently need this feature.

@kisielk
Copy link
Contributor

kisielk commented Jun 7, 2017

@Azuka sounds good, go ahead!

@Azuka Azuka mentioned this pull request Jun 7, 2017
Merged
kisielk pushed a commit that referenced this pull request Jun 8, 2017
@Azuka @kisielk
UnmarshalText precedence with tests (#84)
ca549c5 
* applied jlburkhead's fix
* UnmarshalText prioritized for slices
* Fix Unmarshaler pointer slice decode and add unit tests

Fixes #58 and #64
@kisielk
Copy link
Contributor

kisielk commented Jun 8, 2017

Fixed by #84

@kisielk kisielk closed this Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayowa @kisielk @Azuka