Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct metrics arg in agent creation. #13

Merged
merged 1 commit into from
Aug 26, 2014

Conversation

dipthegeezer
Copy link

Hi

I think the agent is not using the correct argument when creating the metrics.

Thanks

Dip

@gorsuch
Copy link
Owner

gorsuch commented Aug 26, 2014

Hi @dipthegeezer - thanks for the PR! What behavior are you seeing that you'd like to change? Running off of master right now, I'm seeing what I'd expect.

Metrics are being created in the format of haggar.agent.{AGENTID}.metrics.{METRICID}.

@dipthegeezer
Copy link
Author

Hi

I could be wrong here but I thought the metrics argument generates the number of metrics to send to collectd via the agent. It's independent of the number of agents. So for example you could have 10 agents which each send 100 metrics. Given the current code you will always create 10 agents and only send 10 metrics for each agent as it's not using the 'metrics' arg at all. I could be wrong though. ;)

Dip

@gorsuch
Copy link
Owner

gorsuch commented Aug 26, 2014

Ah! Yup! Thanks for the fix!

gorsuch added a commit that referenced this pull request Aug 26, 2014
Use correct metrics arg in agent creation.
@gorsuch gorsuch merged commit 7d8676b into gorsuch:master Aug 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants