Add option to cache connections within each agent #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleinart
force-pushed
the
keep_connections_option
branch
from
a2065ff
to
cbf9b1e
Compare
|
This is great! thank you. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option, -cache_connections (up for better naming suggestions).
Behavior
When specified on the commandline, causes each agent to keep a persistent TCP connection open to the target Carbon instance
Use case
Connection management can be a significant overhead of Carbon. Many clients (e.g. the latest versions of collectd's write_graphite plugin) purposely keep TCP connections open for this reason. Haggar should be able to simulate both clients with persistent connections and transient connections
Testing
Ran haggar with and without -cache_connections specified. Verified via netstat that connections remain open when the option is specified and are closed each time when not.
With -cache_connections specified, verified that when carbon is restarted, connection is reestablished once a send fails