Explicitly nil the agent connection if caching is disabled. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokkojohnny1
force-pushed
the
fix-cached-connection-nil-check
branch
from
8553f16
to
001dd20
Compare
With caching disabled, every alternating metric send fails because it will be attempted on a closed connection - this was the cause of the 50% throughput issue @obfuscurity reported. master: ``` $ ./haggar -agents=3 -metrics=1 -carbon=localhost:2003 -cache_connections=false 2017/01/01 21:28:43 master: pid 36203 2017/01/01 21:28:43 agent 0: launched 2017/01/01 21:28:53 agent 0: flushed 1 metrics 2017/01/01 21:28:55 agent 1: launched 2017/01/01 21:29:03 agent 0: write tcp 127.0.0.1:63932->127.0.0.1:2003: use of closed network connection 2017/01/01 21:29:05 agent 2: launched 2017/01/01 21:29:05 agent 1: flushed 1 metrics 2017/01/01 21:29:13 agent 0: flushed 1 metrics 2017/01/01 21:29:15 agent 2: flushed 1 metrics 2017/01/01 21:29:15 agent 1: write tcp 127.0.0.1:63934->127.0.0.1:2003: use of closed network connection ``` fix-cached-connection-nil-check: ``` $ ./haggar -agents=3 -metrics=1 -carbon=localhost:2003 -cache_connections=false 2017/01/01 21:30:00 master: pid 35558 2017/01/01 21:30:00 agent 0: launched 2017/01/01 21:30:10 agent 0: flushed 1 metrics 2017/01/01 21:30:12 agent 1: launched 2017/01/01 21:30:20 agent 0: flushed 1 metrics 2017/01/01 21:30:22 agent 2: launched 2017/01/01 21:30:22 agent 1: flushed 1 metrics 2017/01/01 21:30:30 agent 0: flushed 1 metrics 2017/01/01 21:30:32 agent 2: flushed 1 metrics 2017/01/01 21:30:32 agent 1: flushed 1 metrics ``` fixes gorsuch#21
|
<3 Thank you @sokkojohnny1! |
|
Verified locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly nil the agent connection if caching is disabled
With caching disabled, every alternating metric send fails because it will be attempted on a closed connection - this was the cause of the 50% throughput issue @obfuscurity reported.
master:
fix-cached-connection-nil-check:
fixes #21