Rspec fixes

[Chadowo]

Hey there, this PR will contain all the rewrite to the RSpec tests of the project.

Details

The changes are pretty straightforward, firstly I ran Rubocop on all the tests and corrected offenses that are safe to do so, then comes updating each test to match with the modern RSpec usage,

[jlnr]

That's a button I hadn't seen before, but I clicked it and it seems to work :)

[Chadowo]

Oh and I've just finished the new README (79bc0ca), it is mostly like the old one but with spell checks, modern Markdown syntax and some changes here and there to understand better the purpose of the text, it looks good in my opinion however I still didn't check it thoroughly.

I also wanted to get some feedback on the changes I've made, and maybe the direction I should head to if you will :D

[jlnr]

The direction of the README looks great to me. 👍 I'm not sure why the GitHub Actions disappeared again. Ah well, we can look at them again in follow-up if necessary.

[jlnr]

Do you have any preferences for how to merge the PR (after shuffling the README files around)? Using a merge commit will add 60+ commits to the history. I'd lean towards squashing it into a single commit for the sake of auditing "what has happened since the fork" using the Git history. Do you think that squashing loses to much information? It looks like Chingu previously used merge commits with full PR history instead.

Also, ping @ippa (hope this ping works) in case you want to give any opinions about this PR. After all, it's the first after the fork. Maybe you decide you want this to happen on the "old" repository after all :)

[Chadowo]

The direction of the README looks great to me. +1 I'm not sure why the GitHub Actions disappeared again. Ah well, we can look at them again in follow-up if necessary.

Thanks for the feedback! and about the Github Actions, on my fork it says there's a syntax error on line 24, this is the code:

    - name: Install dependencies (Ubuntu)
        if: startsWith(matrix.platform, 'ubuntu-') # <- Here
        run: sudo apt-get update && sudo apt-get install -y libsdl2-dev libgl1-mesa-dev libfontconfig1-dev xvfb

      - name: Install dependencies (macOS)
        if: startsWith(matrix.platform, 'macos-')
        run: brew install sdl2
    # [...]

I'm not 100% sure what may it be (I'm a dummy with YML), however looking at the code around it and how other wrote their workflow files I'd suggest something like this to fix it :

    # Starting from the steps
    steps:
    - uses: actions/checkout@v3
    
    # Align if and run indentation with name
    - name: Install dependencies (Ubuntu)
      if: startsWith(matrix.platform, 'ubuntu-')
      run: sudo apt-get update && sudo apt-get install -y libsdl2-dev libgl1-mesa-dev libfontconfig1-dev xvfb

    # Align name with the one above
    - name: Install dependencies (macOS)
      if: startsWith(matrix.platform, 'macos-')
      run: brew install sdl2
  
    # [...]

I don't want to get ahead of myself with conclusions, so I'll wait to get your opinion on the matter first.

Do you have any preferences for how to merge the PR (after shuffling the README files around)? Using a merge commit will add 60+ commits to the history. I'd lean towards squashing it into a single commit for the sake of auditing "what has happened since the fork" using the Git history. Do you think that squashing loses to much information? It looks like Chingu previously used merge commits with full PR history instead.

Hmm, I would also lean towards the squashing path, in my opinion its more minimal and elegant, we could write all the info in the commit summary, it shouldn't be that much confusing in my opinion (if we properly convey the info), what do you think?

[jlnr]

Regarding actions: Yes, oops, looks like I messed up the indentation in my change suggestion. This is the file I have copied it from.

Squashing: Then let's do that once the Actions work again 👍

[Chadowo]

Ok, I'll get to it!

[Chadowo]

I think everything's done, I've finished revising the new README, adjusted the workflow file, and organized the place. Feel free to give it an eye :D

[jlnr]

One last thing, sorry about that.

[jlnr]

I was able to commit (write) my own suggestion! Great, now I can immediately approve.

Thanks a lot for all the hard work here! Will squash & merge as soon as the tests has finished.

[jlnr]

🥳