Diesel example #126

n-pochet · 2018-02-01T21:21:49Z

This PR addresses the issue #77
It is the first draft and could certainly be improved.
Thank you beforehand for your advice and remarks!

bradleybeddoes

Overall this looks like a really great start, very happy to keep working with you on this. 👍

It may be that we hold this example for a short while before merging (once we've sorted out the few identified issues) as the Diesel middleware still needs some rough edges sanded off itself, namely proper async consideration, which will necessitate further change here I am guessing.

bradleybeddoes · 2018-02-05T11:23:55Z

Cargo.toml

@@ -11,4 +11,5 @@ members = [
    "examples/hello_world",
    "examples/hello_router",
    "examples/basic_router",
+    "examples/basic_diesel",


Suggest we call this example simply "diesel"

Indeed. But I still need to name my package in Cargo.toml basic_diesel or I will get a conflict with the real diesel crate.

bradleybeddoes · 2018-02-05T11:24:51Z

examples/basic_diesel/.env

@@ -0,0 +1 @@
+DATABASE_URL=.posts.db


Suggest we hardcode this for the example, goal being to streamline 3rd party overheads/concepts as much as possible.

One of the examples I have planned is going to give some ideas for external configuration loading so we'll cover this then.

bradleybeddoes · 2018-02-05T11:26:58Z

examples/basic_diesel/migrations/2018-01-31-183719_create_posts/down.sql

@@ -0,0 +1,2 @@
+-- This file should undo anything in `up.sql`


suggest remove comment

bradleybeddoes · 2018-02-05T11:27:14Z

examples/basic_diesel/migrations/2018-01-31-183719_create_posts/up.sql

@@ -0,0 +1,7 @@
+-- Your SQL goes here


suggest removing comment

bradleybeddoes · 2018-02-05T11:29:21Z

examples/basic_diesel/src/main.rs

+
+
+// The URL of the database.
+static DATABASE_URL: &'static str = "posts.db";


I note the database was committed, suggest removing the binary, it won't be necessary for folks.

bradleybeddoes · 2018-02-05T11:34:58Z

examples/basic_diesel/src/lib.rs

+}
+
+/// Create the table if needed.
+fn create_table(conn: &SqliteConnection) {


checkout embed_migrations! as part of https://docs.rs/diesel_migrations/1.1.0/diesel_migrations/macro.embed_migrations.html which will help here and cleanup the Err case at https://github.com/gotham-rs/gotham/pull/126/files#diff-92b023737c440588ef77ba19c716ee1eR54

n-pochet · 2018-02-05T11:49:00Z

@bradleybeddoes Thanks for the review. I'll make the changes taking your advice into account.

bradleybeddoes · 2018-02-06T10:21:20Z

I'm just thinking out loud here and feel free to not like this idea, but following my comment on #108 I started considering this PR again.

I was wondering what you thought of also giving this example the 'web store' treatment. Essentially changing it from creating and listing Post to creating and listing Widget as part of the web store "api" that I started to hint at here: https://github.com/gotham-rs/gotham/blob/master/examples/basic_router/src/main.rs#L62

n-pochet · 2018-02-06T10:30:32Z

Sure. It makes more sense to have a "unified" set of examples. I'll change that.
Do you have any idea of what the definition of a Widget should be?

bradleybeddoes · 2018-02-06T10:40:49Z

Oops! I guess this could be very easily confused by folks who haven't seen that before!!.

Perhaps a more universal name here would be Product/products instead of Widget/widgets.

Maybe the products we "sell" could be some of the Rust language merchandise I've seen floating about such as stickers, shirts and the like. e.g:

I'm open to suggestions!

nyarly · 2018-09-29T20:16:26Z

@n-pochet It's been some time since this PR saw attention (from us!) How do you feel about it these days? Should it get a new review pass?

Make it possible to insert `NewPost` by calling the POST method and passing a `NewPost` object in JSON

Rename the example folder from `basic_diesel` to `diesel` Use `embed_migrations!()` to simplify the logic in `lib.rs`

Adapt `README.md` Change the migrations scripts Change all the references (functions and structs)

n-pochet · 2018-11-08T16:53:49Z

Hi @nyarly,

Sorry for the late reply. I have a ton of other projects running.
I rebased and fixed the issues in the example. Feel free to review.

* Change versions in `Cargo.toml` * Use the new versions of the functions

bradleybeddoes · 2019-03-24T23:37:38Z

Closing due to lack of input, please re-open if still a wanted PR.

bradleybeddoes mentioned this pull request Feb 2, 2018

Add example that shows usage of Diesel middleware #77

Closed

bradleybeddoes reviewed Feb 5, 2018

View reviewed changes

n-pochet force-pushed the diesel-example branch 2 times, most recently from 8c88520 to 4a1e9da Compare February 9, 2018 12:51

dsvensson mentioned this pull request Mar 7, 2018

Discuss the roadmap #172

Open

n-pochet added 13 commits November 8, 2018 17:02

add basic_diesel example

5fd8833

rustfmt; add documentation

0e3cc6f

add test

9d18fa5

fix typo

7a15ab4

simplify example by using build_router

1e4bffc

use serde_json

be98e21

Add POST handler

c06b892

Make it possible to insert `NewPost` by calling the POST method and passing a `NewPost` object in JSON

Remove .posts.db

bca489c

Rename folder and simplify lib.rs

175d434

Rename the example folder from `basic_diesel` to `diesel` Use `embed_migrations!()` to simplify the logic in `lib.rs`

Remove comments from migrations scripts

d39b69d

Change Post to Product

f773d50

Adapt `README.md` Change the migrations scripts Change all the references (functions and structs)

Remove dotenv crate dependency

e6480d9

rustfmt

727a36f

n-pochet force-pushed the diesel-example branch from 5bf7744 to bde0f88 Compare November 8, 2018 16:50

Update and rebase

9062a65

* Change versions in `Cargo.toml` * Use the new versions of the functions

n-pochet force-pushed the diesel-example branch from bde0f88 to 9062a65 Compare November 8, 2018 16:54

bradleybeddoes closed this Mar 24, 2019

colinbankier mentioned this pull request Mar 27, 2019

Async Diesel middleware and example #309

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Diesel example #126

Diesel example #126

n-pochet commented Feb 1, 2018

bradleybeddoes left a comment

bradleybeddoes Feb 5, 2018

n-pochet Feb 5, 2018

bradleybeddoes Feb 5, 2018

bradleybeddoes Feb 5, 2018

bradleybeddoes Feb 5, 2018

bradleybeddoes Feb 5, 2018

bradleybeddoes Feb 5, 2018

n-pochet commented Feb 5, 2018

bradleybeddoes commented Feb 6, 2018

n-pochet commented Feb 6, 2018

bradleybeddoes commented Feb 6, 2018

nyarly commented Sep 29, 2018

n-pochet commented Nov 8, 2018

bradleybeddoes commented Mar 24, 2019

		@@ -0,0 +1,2 @@
		-- This file should undo anything in `up.sql`



		// The URL of the database.
		static DATABASE_URL: &'static str = "posts.db";

		@@ -0,0 +1 @@
		DATABASE_URL=.posts.db

Diesel example #126

Diesel example #126

Conversation

n-pochet commented Feb 1, 2018

bradleybeddoes left a comment

Choose a reason for hiding this comment

bradleybeddoes Feb 5, 2018

Choose a reason for hiding this comment

n-pochet Feb 5, 2018

Choose a reason for hiding this comment

bradleybeddoes Feb 5, 2018

Choose a reason for hiding this comment

bradleybeddoes Feb 5, 2018

Choose a reason for hiding this comment

bradleybeddoes Feb 5, 2018

Choose a reason for hiding this comment

bradleybeddoes Feb 5, 2018

Choose a reason for hiding this comment

bradleybeddoes Feb 5, 2018

Choose a reason for hiding this comment

n-pochet commented Feb 5, 2018

bradleybeddoes commented Feb 6, 2018

n-pochet commented Feb 6, 2018

bradleybeddoes commented Feb 6, 2018

nyarly commented Sep 29, 2018

n-pochet commented Nov 8, 2018

bradleybeddoes commented Mar 24, 2019