-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for non-percentage coverage threshold #25
Comments
Interesting idea, I agree that there are some use cases for which percents do not make sense |
Added in v0.1.26
|
+1 Thank you! |
bmeck
pushed a commit
to bmeck/esprima
that referenced
this issue
Nov 22, 2013
Taking advantage of new Istanbul feature, we can guard against coverage regression by specifying maximum uncovered entities, instead of percentage-based thresholds. See gotwarlost/istanbul#25 for details. http://code.google.com/p/esprima/issues/detail?id=388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It could be "minimum uncovered unit". For example, in the case of statement coverage, enforcing 4 out 5 statements can be in the form of:
because only 1 statement should be left uncovered. If someone adds a new line which won't be covered, this triggers the warning.
For some projects, including Esprima itself, this is much more convenient than a percentage-based threshold.
The text was updated successfully, but these errors were encountered: