cleanup unused imports #699
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JuanCanham, I want to accept this PR, especially since fewer imports can increase performance. Thank you so much for your contribution! I am concerned about removing things I don't understand. There are other components in production that aren't fully tested in a dev environment (the API, feed service, and auth bits). Can you elaborate on how you cleaned things up and any testing you did? |
|
I think I just opened it up in vscode, the testing i did was pretty basic. i ran make test, I'll do some more thorough testing and let you know what I actually test next week though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.