feat: add dataset tools and libraries #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
g-linville
requested review from
drpebcak,
thedadams,
njhale,
StrongMonkey and
tylerslaton
thedadams
reviewed
Oct 7, 2024
main.go
Outdated
|
|
||
| func main() { | ||
| if len(os.Args) < 2 { | ||
| fmt.Println("missing argument") |
There was a problem hiding this comment.
Can we add what we expect the argument to be? I see the switch below, but maybe something like missing action as first argument would be more descriptive so the LLM can recover?
There was a problem hiding this comment.
Darren had some specific instructions about what to do for this, so I just updated it to be the way he wants.
|
Moving this to draft because I received more clarification on the design, and there are a lot of things about this that need to change. |
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
|
This one is ready again. |
thedadams
reviewed
Oct 10, 2024
Signed-off-by: Grant Linville <grant@acorn.io>
thedadams
approved these changes
Oct 10, 2024
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
njhale
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds five tools that act as an API for datasets: create and list datasets, and list, get, and add elements to a dataset.
All datasets are represented as a set of files written to disk. Each individual piece of data is stored in a separate file. Depending on how this goes, I may end up creating an interface for datasets in this repo, and have a separate implementation option that stores everything in a single file, in cases where we have several small pieces of data. For now though, this should suffice.