Skip to content

chore: change tool names to be more LLM friendly #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2024
Merged

chore: change tool names to be more LLM friendly #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions pkg/engine/toolname.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package engine

import (
"crypto/md5"
"encoding/hex"
"path/filepath"
"regexp"
"strings"
Expand All @@ -21,20 +19,18 @@ func ToolNormalizer(tool string) string {
if strings.HasSuffix(tool, system.Suffix) {
tool = strings.TrimSuffix(tool, filepath.Ext(tool))
}
tool = strings.TrimPrefix(tool, "sys.")

if validToolName.MatchString(tool) {
return tool
}

name := invalidChars.ReplaceAllString(tool, "-")
name := invalidChars.ReplaceAllString(tool, "_")
if len(name) > 55 {
name = name[:55]
}

hash := md5.Sum([]byte(tool))
hexed := hex.EncodeToString(hash[:])

return name + "-" + hexed[:8]
return name
}

func PickToolName(toolName string, existing map[string]struct{}) string {
Expand Down