Skip to content

bug: tool should be a synonym for tools, not name #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2024
Merged

bug: tool should be a synonym for tools, not name #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 5 additions & 21 deletions pkg/parser/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,9 @@ func isParam(line string, tool *types.Tool) (_ bool, err error) {
}
value = strings.TrimSpace(value)
switch normalize(key) {
case "tool":
fallthrough
case "name":
tool.Parameters.Name = strings.ToLower(value)
case "model":
fallthrough
case "modelname":
case "model", "modelname":
tool.Parameters.ModelName = value
case "description":
tool.Parameters.Description = value
Expand All @@ -92,17 +88,13 @@ func isParam(line string, tool *types.Tool) (_ bool, err error) {
tool.Parameters.InternalPrompt = &v
case "export":
tool.Parameters.Export = append(tool.Parameters.Export, csv(strings.ToLower(value))...)
case "tools":
case "tool", "tools":
tool.Parameters.Tools = append(tool.Parameters.Tools, csv(strings.ToLower(value))...)
case "args":
fallthrough
case "arg":
case "args", "arg", "param", "params", "parameters", "parameter":
if err := addArg(value, tool); err != nil {
return false, err
}
case "maxtoken":
fallthrough
case "maxtokens":
case "maxtoken", "maxtokens":
tool.Parameters.MaxTokens, err = strconv.Atoi(value)
if err != nil {
return false, err
Expand All @@ -113,15 +105,7 @@ func isParam(line string, tool *types.Tool) (_ bool, err error) {
return false, err
}
tool.Parameters.Cache = &b
case "jsonmode":
fallthrough
case "json":
fallthrough
case "jsonoutput":
fallthrough
case "jsonformat":
fallthrough
case "jsonresponse":
case "jsonmode", "json", "jsonoutput", "jsonformat", "jsonresponse":
tool.Parameters.JSONResponse, err = toBool(value)
if err != nil {
return false, err
Expand Down