Skip to content

Add Treasure Hunt #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 9, 2024
Merged

Add Treasure Hunt #262

merged 11 commits into from
May 9, 2024

Conversation

techmaharaj
Copy link
Contributor

Adding example for a treasure hunt game.

@techmaharaj
Copy link
Contributor Author

@cloudnautique can you review this?

@techmaharaj
Copy link
Contributor Author

@cloudnautique can you please review this?

Signed-off-by: Atulpriya Sharma <sharma.atulpriya@gmail.com>
Signed-off-by: Atulpriya Sharma <sharma.atulpriya@gmail.com>
@cloudnautique
Copy link
Contributor

If we are going to host this on Render, can we add a Docker container? Similar to how the gptscript-ai/story-book app is done? Also, the file is hardcoded, so concurrent users would stomp on each other, would be good if that were dynamic.

It doesn't look like you are using any external tools, so you wouldn't need to run gptscript --assemble to aggregate everything at build time.

@techmaharaj
Copy link
Contributor Author

If we are going to host this on Render, can we add a Docker container? Similar to how the gptscript-ai/story-book app is done? Also, the file is hardcoded, so concurrent users would stomp on each other, would be good if that were dynamic.

It doesn't look like you are using any external tools, so you wouldn't need to run gptscript --assemble to aggregate everything at build time.

Hi @cloudnautique this is done, please have a look.

Signed-off-by: Atulpriya Sharma <sharma.atulpriya@gmail.com>
Signed-off-by: Atulpriya Sharma <sharma.atulpriya@gmail.com>
Signed-off-by: Atulpriya Sharma <sharma.atulpriya@gmail.com>
@techmaharaj
Copy link
Contributor Author

Hi @cloudnautique I've fixed all the comments, please check.

Signed-off-by: Atulpriya Sharma <sharma.atulpriya@gmail.com>
Signed-off-by: Atulpriya Sharma <sharma.atulpriya@gmail.com>
@cloudnautique cloudnautique merged commit 6eb7102 into gptscript-ai:main May 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants