fix(workers): strip non-serialize fields in extra
with LogMessageWithStack.toRawData
#4287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogMessageWithStack.toRawData
's entire purpose is to sanitize thepostMessage
call insidereportTestResults
, which it is definitely not doing in the case ofextra
. Strip anything not serializable usingJSON.stringify
andJSON.parse
.Without this, we get failures in worker contexts when extra debugging is specified for tests.
Issue: #4172
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.