π 12/12 @ 12:00pm PT - Refactoring a 10+ years old code base: nock (Part V) #58
Closed
13 of 16 tasks
Labels
show
Preparation issue for a live show
ππ» Refactoring a 10+ years old code base: nock (Part V)
π Sunday, December 12, 2021
π 12:00am Pacific Time
ποΈ no guests
π https://www.twitch.tv/gregorcodes
π·οΈ automation
Subscribe to this issues to get a notification before the show begins and a summary after the show concludes.
Refactoring a 10+ years old code base: nock (Part V)
I will continue my refactoring work from first 3 weeks: #55, #54, #53
A humble version of the
intercept
module is ready and I changednock
's code to use it. Some tests are already passing. This week, I'll try to get as many of the remaining tests to pass as possible, maybe move some tests into the new module where it makes sense.If we get all existing tests to pass and reach 100% test coverage again, I'll move the internal intercept module to its own repository and publish it as its own npm module.
Outline
tests/test_client_request.js
tests/test_request_overrider.js
tests/test_abort.js
tests/test_allow_unmocked.js
tests/test_allow_unmocked_https.js
tests/test_events.js
tests/test_net_connect.js
tests/test_reply_headers.js
tests/test_socket.js
URL
api parse a request string and make sure we set all the properties. Have another look at what the nativehttp.RequestClient
api is doing.nock
codebase. Remove no longer used code and obsolete tests.nock/intercept
repository and move the internal module therenock
TODOs
Before the show
prepare recap of what I've done so far
(https://twitter.com/gr2m/status/1470113748614533127)
(π 12/12 @ 12:00pm PT - Refactoring a 10+ years old code base: nock (Part V)Β #58 (comment))
When show begins
(https://twitter.com/gr2m/status/1470120943292981255)
(π 12/12 @ 12:00pm PT - Refactoring a 10+ years old code base: nock (Part V)Β #58 (comment))
(https://twitter.com/gr2m)
After the show
Recording
will be added after the show
Shownotes
will be added after the show
The text was updated successfully, but these errors were encountered: