Skip to content

Rename ParticipantTypeAgent to ParticipantTypeHumanAgent #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2024
Merged

Rename ParticipantTypeAgent to ParticipantTypeHumanAgent #5

merged 1 commit into from
Mar 21, 2024

Conversation

nlathia
Copy link
Member

@nlathia nlathia commented Mar 20, 2024

Also 🤏 tiny nit in the API - the bot is referred to as the agent throughout the docs, but ParticipantTypeAgent is a human. Not a big deal and realise it's not wrong, but I was briefly confused.
Could maybe disambiguate with e.g. ParticipantTypeHumanAgent or similar ☺️

@nlathia nlathia requested a review from boxofrad March 20, 2024 22:14
@nlathia nlathia merged commit 46d2276 into main Mar 21, 2024
@nlathia nlathia deleted the rename-agent-type branch March 21, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@boxofrad boxofrad boxofrad approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlathia @boxofrad