-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown issues #3549
Dropdown issues #3549
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3549-all-demos |
Tested and works well @aliabid94. Nice PR! |
LGTM 👍 |
Actually there's one issue I found, it has to do with the multiselect dropdown Every other time you click on a choice it closes the list, even though you could still select/unselect other options output.webm |
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
Fixed the issue space nuko pointed out. Also moved the dropdown so it does not cover the input text. Also now you can type to search when multiselect=False, fixes #3538 |
Nice fixes @aliabid94! Thanks for raising these great issues @space-nuko |
This PR fixes a lot of the dropdown issues raised by @space-nuko. GIF below shows new behavior of dropdown:
code for demo at bottom.
Changes in this PR:
gr.Dropdown
doesn't close when clicked on twice #3532)gr.Dropdown
items can get cut off at the bottom of the page #3539, fixes:gr.Dropdown
's default size is much too small #3530).gr.Dropdown
can cause X overflow/ugly scrollbars #3533)gr.Dropdown
items when multiselect is off #3538)