Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gradle logger instead of println in dependency graph init script #191

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

aleksandrserbin
Copy link
Contributor

Dependency graph generation script should respect gradle's logger settings. For example, when -q supplied, "Generating dependency graph into" message should not be printed

@bgalek
Copy link

bgalek commented Apr 19, 2024

@bigdaz please take a look, this is a big improvement for us :)

@bigdaz bigdaz merged commit 6ccde15 into gradle:main Apr 19, 2024
60 checks passed
@bigdaz bigdaz added this to the v3.4 milestone Apr 19, 2024
@bgalek
Copy link

bgalek commented Apr 19, 2024

@bigdaz thank you! You are super responsive :)

@bgalek
Copy link

bgalek commented Apr 19, 2024

@bigdaz, are you interested in our company usage of this action?
We're migrating ~1500 repositories now ;)

@bigdaz
Copy link
Member

bigdaz commented Apr 19, 2024

@bgalek Yes I'm very interested in how you're doing it and what your experience is. Please share as much as you can. DM me if that's preferable.

We are just starting to promote the project: https://blog.gradle.org/gradle-github-partnership-supply-chain-security
Note that resolving alerts isn't always straightforward:

@bigdaz
Copy link
Member

bigdaz commented Apr 19, 2024

The Gradle Community Slack is a good place to discuss: https://gradle.org/slack-invite

@bgalek
Copy link

bgalek commented Apr 19, 2024

I'll catch you there than :)

@bgalek
Copy link

bgalek commented Apr 25, 2024

@bigdaz do You have a v3.3.2 release date? :)

@bigdaz bigdaz changed the title Use logger in dependency graph init script Use Gradle logger instead of println in dependency graph init script Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants