Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate IncrementalTaskInputs #9048

Closed
wolfs opened this issue Mar 22, 2019 · 6 comments · Fixed by #19202
Closed

Deprecate IncrementalTaskInputs #9048

wolfs opened this issue Mar 22, 2019 · 6 comments · Fixed by #19202
Assignees
@wolfs
Milestone
7.5 RC1

Comments

@wolfs
Copy link
Member

wolfs commented Mar 22, 2019

Everybody should use InputChanges.
@wolfs
Copy link
Member Author

wolfs commented Apr 1, 2019

We should do the deprecation only when Gradle's built-in tasks don't use the old API any more. When that happens, we also should de-incubate InputChanges. I guess both things should happen fro 6.0.

@lptr lptr transferred this issue from another repository Apr 15, 2019
@lptr lptr added this to the 6.0 RC1 milestone Apr 15, 2019
@lptr
Copy link
Member

lptr commented May 24, 2019

We need to do #9052 before we can deprecate IncrementalTaskInputs.

@wolfs
Copy link
Member Author

wolfs commented Sep 4, 2019

Let's deprecate it for 6.0 and start nagging in 7.0.

@wolfs wolfs self-assigned this Sep 6, 2019
@wolfs wolfs mentioned this issue Sep 6, 2019
Merged
@wolfs wolfs modified the milestones: 6.0 RC1, 7.0 RC1 Sep 11, 2019
@wolfs
Copy link
Member Author

wolfs commented Sep 11, 2019

The non-nagging deprecation has been done as part of #10490.

@nedtwigg nedtwigg mentioned this issue May 9, 2020
Closed
3 tasks
@lptr lptr modified the milestones: 7.0 RC1, 6.8 RC1 Aug 18, 2020
@wolfs wolfs modified the milestones: 6.8 RC1, 7.0 RC1, 6.9 RC1 Nov 20, 2020
@lptr lptr mentioned this issue Dec 10, 2020
Closed
4 tasks
@wolfs wolfs modified the milestones: 7.0 RC1, 7.1 RC1 Jan 15, 2021
@melix melix assigned melix and unassigned wolfs May 6, 2021
melix added a commit that referenced this issue May 6, 2021
@melix
Nag user when using IncrementalTaskInputs
c9f9999 
This commit fully deprecates `IncrementalTaskInputs` by nagging the
user whenever a task action uses this type.

Closes #9048
@melix melix mentioned this issue May 6, 2021
Closed
@melix
Copy link
Contributor

melix commented May 7, 2021

I'm removing the 7.1 milestone because #17115 showed that we first need a release of the Kotlin plugin which doesn't use the old API.

@melix melix modified the milestones: 7.1 RC1, 7.2 RC1 May 7, 2021
@wolfs wolfs modified the milestones: 7.2 RC1, 7.3 RC1 Jul 5, 2021
@lptr lptr modified the milestones: 7.3 RC1, 7.4 RC1 Sep 20, 2021
@lptr lptr assigned wolfs and unassigned melix Dec 2, 2021
@wolfs wolfs mentioned this issue Dec 2, 2021
Merged
@wolfs wolfs modified the milestones: 7.4 RC1, 7.5 RC1 Dec 2, 2021
@wolfs
Copy link
Member Author

wolfs commented Dec 2, 2021

Kotlin 1.6 seems to have moved to InputChanges: JetBrains/kotlin@7b6dddf

So we can do this as still as Gradle moves to Kotlin 1.6.x

@wolfs wolfs modified the milestones: 7.5 RC1, 7.6 RC1 Mar 10, 2022
@wolfs wolfs modified the milestones: 7.6 RC1, 7.5 RC1 Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolfs wolfs

Labels
None yet
Projects
None yet
Milestone
7.5 RC1
4 participants
@melix @wolfs @lptr @jjohannes