Mark empty selectors failed in case resolution fails #6676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melix
approved these changes
Sep 7, 2018
ljacomet
force-pushed
the
ljacomet/dependency-management/empty-selector
branch
2 times, most recently
from
5a35ff0
to
322f689
Compare
Changes that skipped empty selectors caused them to end in a resolved state without a failure nor a selected target component. This commit fixes the failure case as it was causing a NPE during failure collection. Fixes #6675
This change aims at preventing any resize from happening at the cost of higher memory consumption for a short time.
ljacomet
force-pushed
the
ljacomet/dependency-management/empty-selector
branch
from
322f689
to
ecec46e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes that skipped empty selectors caused them to end in a resolved
state without a failure nor a selected target component. This commit
fixes the failure case as it was causing a NPE during failure
collection.