Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid config is ignored #30

Closed
rfratto opened this issue Mar 18, 2020 · 0 comments · Fixed by #31
Closed

Invalid config is ignored #30

rfratto opened this issue Mar 18, 2020 · 0 comments · Fixed by #31
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@rfratto
Copy link
Member

rfratto commented Mar 18, 2020

When validating the config fails, the process should exit rather than continuing on as normal:

agent/cmd/agent/main.go

Line 77 in b0016d2

level.Error(util.Logger).Log("msg", "failed to create prometheus instance", "err", err)

@rfratto rfratto added the bug Something isn't working label Mar 18, 2020
@rfratto rfratto mentioned this issue Mar 18, 2020
Merged
rfratto pushed a commit that referenced this issue Dec 8, 2021
@mattdurham
Merge pull request #30 from grafana/integrations_0_20_1_take2
042dac5 
Merge changes from integrations secret to 0.20.1
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exit process after error validating config or starting server rfratto/agent
1 participant
@rfratto