-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release instructions for release branch #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but personally that step doesn't seem to be that valuable if the only benefit is that the install instructions could be generic.
Fair argument, we only need it so we don't have to keep updating grafana.com with new instructions every time we do a release here. |
Can it not just say pick the latest version from https://github.com/grafana/agent/releases and substitute it into your |
Sorry, I'm being too vague here. The installation script as it is now asks you for your remote write URL and basic auth info. The instructions on grafana.com will modify the command slightly to pass that through environment variables so the user isn't prompted for input. So in that case it'll just be a "copy this, paste it, run it, and the Agent is installed and sending data to Grafana Cloud." |
In that case, if the release script downloads via |
I agree with the point here: we should definitely have a script that installs the latest release rather than having to manage a release branch. Unfortunately, I do want to move this forward so I'm going to merge this for now and open an issue to improve this process. |
Co-authored-by: Erik Baranowski <39704712+erikbaranowski@users.noreply.github.com>
A
release
branch has been added to always refer to the latest release tag. This must be updated as part of the post-release process. Instructions on doing this have been added to the maintainers manual.