Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions for release branch #35

Merged
merged 1 commit into from Mar 24, 2020

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Mar 24, 2020

A release branch has been added to always refer to the latest release tag. This must be updated as part of the post-release process. Instructions on doing this have been added to the maintainers manual.

Copy link

@cstyan cstyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but personally that step doesn't seem to be that valuable if the only benefit is that the install instructions could be generic.

@rfratto
Copy link
Member Author

rfratto commented Mar 24, 2020

Fair argument, we only need it so we don't have to keep updating grafana.com with new instructions every time we do a release here.

@cstyan
Copy link

cstyan commented Mar 24, 2020

Can it not just say pick the latest version from https://github.com/grafana/agent/releases and substitute it into your curl/wget/etc command?

@rfratto
Copy link
Member Author

rfratto commented Mar 24, 2020

Sorry, I'm being too vague here.

The installation script as it is now asks you for your remote write URL and basic auth info. The instructions on grafana.com will modify the command slightly to pass that through environment variables so the user isn't prompted for input. So in that case it'll just be a "copy this, paste it, run it, and the Agent is installed and sending data to Grafana Cloud."

@cstyan
Copy link

cstyan commented Mar 24, 2020

In that case, if the release script downloads via https://github.com/grafana/agent/releases/latest via a call that allows redirect (curl -L for example) you'll always get the latest release.

@rfratto
Copy link
Member Author

rfratto commented Mar 24, 2020

I agree with the point here: we should definitely have a script that installs the latest release rather than having to manage a release branch.

Unfortunately, I do want to move this forward so I'm going to merge this for now and open an issue to improve this process.

@rfratto rfratto merged commit 793f32f into grafana:master Mar 24, 2020
@rfratto rfratto deleted the update-release-instructions branch March 24, 2020 21:45
wildum pushed a commit that referenced this pull request Apr 9, 2024
Co-authored-by: Erik Baranowski <39704712+erikbaranowski@users.noreply.github.com>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label May 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants