Update otelcol.receiver.prometheus with v0.87.0 opentelemetry collector contrib version #5799
Conversation
There was a problem hiding this comment.
Suppose we have an otel_scope_info metric with three labels -otel_scope_name, otel_scope_version, and another one. If we pass it through otelcol.receiver.prometheus and then through otelcol.exporter.prometheus, will we end up with the same series as the one we started with?
There was a problem hiding this comment.
the otel receiver now drops otel_scope_info metric so if you do prometheus -> otel -> prometheus and if one of your prometheus metric was named otel_scope_info, the otel receiver will get rid of it and it wont be there when converting it back to prometheus (I tested it)
Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
There was a problem hiding this comment.
Than you, LGTM! As long as the branch is rebased and Clayton's comments are addressed, I'm happy for it to be merged.
It'd be nice if the scenario in this comment is tested s well, but it's not a must. The reason I asked for this is that the changes to otel_scope_info might break this behaviour for users who rely on it.
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell
added
the
type/docs
…or contrib version (grafana#5799) * copy pasted code from opentelemetry, no manual change * Update docs/sources/flow/release-notes.md --------- Co-authored-by: Paulin Todev <paulin.todev@gmail.com> Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
github-actions
bot
added
the
frozen-due-to-age
PR Description
Check the CHANGELOG.md to see the list of changes.
I added tests for the exemplars support and the otel_scope_info.
Which issue(s) this PR fixes
Fixes #5313
Notes to the Reviewer
The only changes made in the internal folder were to solve linting issues.
PR Checklist