Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race conditions and flaky CI #90

Merged
merged 4 commits into from
May 26, 2020
Merged

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented May 21, 2020

This PR fixes the various flakes CI has been having lately.

@rfratto
Copy link
Member Author

rfratto commented May 21, 2020

🤞 going to rerun the CI a bunch of times and hopefully nothing fails. If everything is good, I'll open this up for review

@rfratto rfratto marked this pull request as ready for review May 21, 2020 21:47
@rfratto
Copy link
Member Author

rfratto commented May 21, 2020

I've tested it for a good hour and everything passed every time, I'm pretty confident this fixes the flakiness.

@rfratto rfratto requested review from hoenn and gotjosh May 21, 2020 21:47
@rfratto rfratto mentioned this pull request May 26, 2020
@rfratto rfratto merged commit 36817fb into grafana:master May 26, 2020
@rfratto rfratto deleted the race-conditions branch February 22, 2021 15:38
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
* enable testing for race conditions

* stop using mock etcd

mock etcd was the source of a lot of flakes

* fix reported race conditions

* fix lint error
wildum pushed a commit that referenced this pull request Apr 9, 2024
* Rename the config language directory

* Update the metadata

* Update docs/sources/concepts/configuration-syntax/_index.md
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants