use remote_write and scrape_config validations from Prometheus #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus was doing some validations on the remote_write and scrape_config sections per config that we weren't doing yet. To make this a little easier, ApplyDefaults and Validate have been merged. The scraping service PutConfiguration endpoint will now apply the defaults to the config before passing it through to the KV store; invalid configs will be prevented from reaching the KV store and errors will be returned to the client. When migrating to this change, if any invalid configs exist in the KV store, the Agent will refuse to start them and log an error. The configs in the KV store should be updated to fix the invalid settings before the Agent will be able to run it. Fixes #80.
Closed
hoenn
reviewed
May 26, 2020
hoenn
approved these changes
May 26, 2020
rfratto
referenced
this pull request
in rfratto/agent
May 27, 2020
PR #92 accidentally removed unmarshaling the default config values into the instance configs.
rfratto
added a commit
that referenced
this pull request
May 27, 2020
* add back in instance config default values on unmarshal PR #92 accidentally removed unmarshaling the default config values into the instance configs. * add more tests and a new validation * fix test failures
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* use remote_write and scrape_config validations from Prometheus Prometheus was doing some validations on the remote_write and scrape_config sections per config that we weren't doing yet. To make this a little easier, ApplyDefaults and Validate have been merged. The scraping service PutConfiguration endpoint will now apply the defaults to the config before passing it through to the KV store; invalid configs will be prevented from reaching the KV store and errors will be returned to the client. When migrating to this change, if any invalid configs exist in the KV store, the Agent will refuse to start them and log an error. The configs in the KV store should be updated to fix the invalid settings before the Agent will be able to run it. Fixes #80. * add tests for new validations * s/ok/exists
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* add back in instance config default values on unmarshal PR #92 accidentally removed unmarshaling the default config values into the instance configs. * add more tests and a new validation * fix test failures
wildum
pushed a commit
that referenced
this pull request
Apr 9, 2024
* internal: migrate to standard Grafana stability definitions This commit changes the stability levels to align with [Grafana's standard set][1]: * Experimental / `experimental` (unchanged) * Public preview / `public-preview` (previously "beta") * Generally available / `generally-available` (previously "stable") [1]: https://grafana.com/docs/release-life-cycle/ * internal/featuregate: explain why Private preview is not included
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus was doing some validations on the
remote_writeandscrape_configsections per config that we weren't doing yet. To make this a little easier, ApplyDefaults and Validate have been merged.The scraping service PutConfiguration endpoint will now apply the defaults to the config before passing it through to the KV store; invalid configs will be prevented from reaching the KV store and errors will be returned to the client.
When migrating to this change, if any invalid configs exist in the KV store, the Agent will refuse to start them and log an error. The configs in the KV store should be updated to fix the invalid settings before the Agent will be able to run it.
Fixes #80.