Attempting to get or delete a config which does not exist 404's #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Kyle! @mattdurham can you review this? |
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
rfratto
added a commit
that referenced
this pull request
Dec 15, 2021
* Register missing metric (#860) * register missing metric for configstore consul list duration * rename metric * rename metric (operation type is a label) * Add caller information to logs (#861) * Rename prometheus to metrics (#882) * alias `prometheus` as `metrics` and note deprecation * changelog/upgrade guide * defensively ensure defaults are loaded in to deprecated prometheus struct * Update metrics in mixin (#878) * Add namespace to some queries which were missing it * Move samples queries to samples row, update to current metric names, and allow some graphs to work with multiple instance groups * Update example dashboards with changes * Rename panel to match metric * Honor config refresh timeout, remove timeout for lifecycle and instead use background context (#876) * Honor config reshard timeout, remove timeout for lifecycle and instead use background check. * Added timeout and background refresh * add debugging information around deadline * add debugging information around deadline, add new setting for timeouts, and use that timeout * Fix cancel and refresh->reshard naming * Catch cancel if not joining. * Catch cancel if not joining. * Make the linter happy * Change comments. * Changes recommended from PR, most importantly is moving the goroutine to the reshard instead of the caller to reshard. * Fix changelog * Match err with log. * Move mutex inside goroutine * Update changelog with 877 fix * Revert to previous behavior * Scraping service: use buffered channel for requesting refreshes (#886) * refresh queue, remove mut * fix logs * more logs! * how many logs can i add? * how many logs can i change? * more logging * changelog * Automated smoke tests for metrics (#825) * poc smoke test automation * finish smoke test environment * debug logs * fix typo, sync immediately * add crow, add crow-related alerts * have v0 and v1 libs use v2 lib * basic cpu, memory tests * fix chaos_loop to stop generating replica -3 which will never exist * Add initial documentation for crow. * update comments * Add uml * Cleanup documentation * Reformate/move docs * Fix some verbiage * Fix doc checking * Update cmd/grafana-agent-crow/README.md Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Small nits * Fix pathing in readme Co-authored-by: Matt Durham <mattdurham@ppog.org> * Move port to load_balancing config as receiver_port (#881) * Move port to load_balancing config as receiver_port When extracting load balancing from tail sampling, only the the load_balancing block was moved into its own block, but the receiver's port was left in tail_sampling. This means that the receiver port for load_balancing could not be configured without tail_sampling. Now its moved to load_balancing as receiver_port. * Load balance without tail sampling * Move port up * agentctl: allow specifying Grafana Cloud's API url in cloud-config cmd (#898) * add docs sync (#897) * prepare for v0.18.3 release (#899) * rename prom_instance -> metrics_instance (#905) * Containerize merges to development branches (#893) * Containerize merges to development branches * Update drone.yml Updated drone signature Co-authored-by: mattdurham <mattdurham@ppog.org> * Ensure reshards are scheduled every reshard_interval (#912) * ensure reshards are scheduled every reshard_interval * use single metric for config changed events * logs * Prepare for 0.18.4 release (#913) * prepare for 0.18.4 release * include #831 * simplify logic a little for calculating next reshard (#917) * tempo: if relabel config drops target, don't attempt to process (#904) (#906) This avoids e.g. logging a warning when a target is intentionally dropped * Update for `## Deploy GrafanaAgent` clusterrole (#923) Update `## Deploy GrafanaAgent` section to include additional kubelet metrics. Reason: When checking the metrics sent to Grafana Cloud, we noticed that some of kubelet metrics (cpu/memory usage) was missing. On the agent, we are using the backwards compatibility with the Prometheus Operator CRDs ServiceMonitor and PodMonitor , so that metric instance discovery is exactly as it is with our hosted prometheus. * Rename Tempo -> Traces (#909) * Initial run through on changing tempo -> traces * Second run through of changing tempo->traces * Update changelog * Fix dead link * Clean up readme * Clean up changelog * Rename to fit pattern * Fix k8s build * Change to deprecate instead of enhancement, make tests and implement backwards compatibility * Rename traces config until aliasing is known * update to tempo-config * PR feedback * Update doc * Convert in k8s RBAC api calls version from /v1beta1 to stable /v1 (#925) * Convert RBAC api version from /v1beta1 to stable /v1 From the documentation: RBAC resources The rbac.authorization.k8s.io/v1beta1 API version of ClusterRole, ClusterRoleBinding, Role, and RoleBinding is no longer served as of v1.22. Migrate manifests and API clients to use the rbac.authorization.k8s.io/v1 API version, available since v1.8. All existing persisted objects are accessible via the new APIs * Update jsonnet lib alpha-1.14 to stable-1.21 * Update changelog * Sync of vendor files * update .gitignore to be explicit about root paths (#932) * Mixin Dashboard Updates (#931) * Show targets by pod * Switch active series back to appended samples * Add a new samples rate panel * 1hour time range and 30s refresh for dashboards * Update example dashboards with changes * Add the agent-operational dashboard to the mixin * docs & tanka changes for s/loki/logs rename (#739) * docs & tanka changes for s/loki/logs rename * add alias for logs-config * remove aliasing * Standardize default scrape interval to 1m (#939) * Set default scrape_interval to 1m * Add envsubst to drone * Update changelog * Making configurable what method is used when adding k/v to spans (#920) * Making configurable what method is used when adding k/v to spans * Remove weird diff * Remove new nesting * Add operationType validation * CHANGELOG * Rename Prometheus to Metrics in docs / jsonnet (#940) * rename prometheus to metrics in docs / jsonnet * oops * Add note about using backslashes and backticks (#942) * Add note about using backslashes and backticks We need to note users about using backslashes in agent config file, and about not supported backticks too. Also I've added error messages text for quicker finding the solution by error text. * More detailed info about backslashes in regex * re-prefix metrics-subsystem metrics (#943) * Release v0.19.0 (#952) * Update changelog, versioning and some errors that slipped through * update path correctly * Updated the memory test with @rfratto suggestion to up the avalanche parameters to not get preemptive errors on memory. * Release v0.19.0 (#954) * Update changelog, versioning and some errors that slipped through * update path correctly * Updated the memory test with @rfratto suggestion to up the avalanche parameters to not get preemptive errors on memory. * Use correct package name for envsubst * Use correct package name for envsubst * Operator: Add support for managing a kubelet service (#907) * add support for managing a kubelet service * write test for kubelet reconciler * add example ServiceMonitor for the kubelet service * add instructions for kubelet ServiceMonitor * Update documentation with better release note and contributions (#956) * Update documentation * PR feedback changes * update docs link in deb/rpm service files (#945) * Upgrading Integration Dependencies (#944) * upgrading integrations depencies: elasticsearch, redis, postgres, mysql, memcached, statsd * Updating changelog * Updating changelog * Fix changelog typo * updating postgres exporter repo address on documentation * CheckKeyGroupsBatchSize directed to CheckKeysBatchSize configuration property * solving broken link * Add note about ports in tempo remote_write enpoint (#953) * Note about ports in tempo remote_write enpoint Added comment with examples how to fill port of `remote_write` tempo endpoint for local and on-premises instances. For new users it's unclear which port to choose, and in most cases they try to fill the default `3200` Tempo port, instead of gRPC receiver port. * Update docs/configuration/traces-config.md Co-authored-by: mattdurham <mattdurham@ppog.org> * Replace dots for underscores in autologged labels (#951) * Replace dots for underscores in autologged labels * Use SanitizeLabel function * Update changelog with some bad merges that added notes to v0.19.0 (#959) * Update changelog with some bad merges * Flatten out dependencies and give shoutout to (@gaantunes) * Add silent install to windows (#969) * Add silent install to windows * Add silent install to windows * remove extra colon * Update mongodb_exporter to release-0.27.0-grafana (#965) * update mongodb_exporter to release-0.27.0-grafana * fix lint errors * Update pkg/integrations/mongodb_exporter/mongodb_exporter.go Co-authored-by: gaantunes <g.amaral.antunes@gmail.com> * add note for compatiblemode Co-authored-by: gaantunes <g.amaral.antunes@gmail.com> * bump version of dnsmasq_exporter used (#973) * docs/operator: stop using FQDN for kube-apiserver __address__ (#972) This example only works when cluster domain is set to cluster.local. When the cluster domain is changed, scraping silently fails (hidden behind the "debug" log level): grafana-agent ts=2021-10-08T15:10:06.054149178Z level=debug agent=prometheus instance=320d908d14feeac9f916f752b6276792 component="scrape manager" scrape_pool=integrations/kubernetes/cadvisor target=https://kubernetes.default.svc.cluster.local:443/api/v1/nodes/ns100566-865ef3ad/proxy/metrics/cadvisor msg="Scrape failed" err="Get "https://kubernetes.default.svc.cluster.local:443/api/v1/nodes/ns100566-865ef3ad/proxy/metrics/cadvisor\": dial tcp: lookup kubernetes.default.svc.cluster.local on 10.43.0.10:53: no such host" Luckily, kubernetes also populates /etc/resolv.conf with search domains, so we can simply specify kubernetes.default.svc, and it works with all cluster domains. * Upgrade OTel to v0.36 (#971) * Upgrade OTel to v0.36 * Add replace for jaeger * Remove conversion * changelog * lint * Remove g1.17 annotations * Lint again * Left annotation change * Correct minor spelling mistake in comments (#977) * Update examples, docs for name changes, deprecations. (#978) * Add Hanif to Governance (#979) * traces: remove extra line feed in password file (#976) cf. 975. This is to match loki and prometheus behavior * Update statsd to latest release and change a few things around the cache (#985) * Update statsd to latest release and change a few things around the cache * standardize verbiage * remove unneeded mappercache * Replace perflib_exporter to use forked version that remove prometheus/log (used implicitly by windows_exporter) (#989) * Replace directive for perflab_exporter that windows_exporter uses so we can remove reliance on prometheus logging * update changelog * Update CHANGELOG.md Clean up changelog * [Documentation] Adding DandyDev public Grafana Agent chart (#987) * Adding DandyDev public Grafana Agent chart * Updating per reccomendations in review. * List the Grafana Agent charmed operator in the community projects (#994) * Do not immediately cancel promServiceDiscoProcessor's discoveryMgrCtx (#998) * Do not immediately cancel promServiceDiscoProcessor's discoveryMgrCtx * Add more information to changelog * Attempting to get or delete a config which does not exist 404's (#995) * [Tracing] Service graphs (#988) * Service graphs processor (#756) * Bare implementation of the service graph processor * Comment fixes * Collect unpaired spans metric * Add unpaired metric * Implementation improvements * Some more improvements * No need to close * Fix CI * Improve test stability * Some documentation * Fix tests * Truly fix it * Check span error (#901) * Check span's error * Also check http status code * Update tests * Inspect http and grpc status too * Use map for performance * Cleanup * Count number of dropped spans and remove untagged metric (#967) * Fix CHANGELOG * Extend docs * Fix pipelines * Add note for metrics' namespace * Scrape only local endpoint docker-compose * Rename metrics: tempo -> traces * Gaantunes/docs security recommendations (#1003) * Including security recommendations on docs, to restrict user privileges were secrets are necessary * Updatintg CHANGELOG.md * Fixing typos * Update windows_exporter to v0.16.0 (#990) * update windows_exporter to 0.16.0 * add go.mod note to block merging * disable textfile collector by default * go mod tidy, use latest release branch commit * upgrade to github.com/drone/envsubst/v2 (#1004) * upgrade to github.com/drone/envsubst/v2 * update changelog * add github.com/drone/envsubst/v2 to depcheck * re-organize changelog * update out of place BUGFIX in changelog * update depcheck * Document changes due to OTel upgrade (#1011) * Document changes due to OTel upgrade * Fix doc link * It breaks things! * add grafana agent community call (#1016) * pkg/operator: only delete managed resources (#1027) * pkg/operator: only delete managed resources Also ensures that all managed resources have the managed-by label * optimize isManagedResource * Fully deprecate push_config (#1010) * Fully deprecate push_config * Document change in upgrade guide * prepare for v0.20.0 release (#1041) * Update _index.md (#1032) * Update _index.md * Update _index.md * fix upgrade guide (#1043) * Show remote write latency on dashboard (#1051) If samples are getting backlogged, it may be due to latency between the agent and the backend it is sending to. Replaced the differential panel which doesn't add much to the timestamp panel to the left, and essentially duplicates the differential samples rate panel below. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * Log config watcher reshard timer at debug level (#1050) Since this message is logged periodically and an implementation detail we can log it at a debug level. Resolves #1048 * Use correct user/group env variables (#1053) * Use correct user/group env variables The env variables in add_to_logging_group() did not match the names set at the start of the post install script. * Update CHANGELOG.md * Validate logs config when using logs_instance (#1058) * Change integrations to have a unique instance key (#1033) * wip: generate instance key from integration configs * remove accidentally committed file * refactor manager to support instance keys * docs changes * fix typo Co-authored-by: Ryan Geyer <me@ryangeyer.com> Co-authored-by: Ryan Geyer <me@ryangeyer.com> * Operator: Fix metrics service port (#1060) * Fix metrics service port * Create a govern metrics service per Grafana Agent (#1065) * Add metrics service per Grafana Agent * Update changelog * Remove dead code * Operator: Add relabel_config.libsonnet to logs templates dir (#1064) * Add relabel_config.libsonnet to logs templates dir * Update CHANGELOG.md * Service graphs performance improvements (#1022) * Ditch cache library for map + mutex The implementation with the cache library had a ver bad performance, specially when calling `Items()`, since it would create a new map and copy all items to it. This commit changes the implementation to use a map with a mutex. * Clean up and comments * Correctly set expiration time * Notify of ready edges instead of looping through all * Use list to store edges * Minor fixes and comments * Properly check when head edge should be evicted * Remove old logic from previous implementations * Extract store to its own struct * Remove ugly copy * Fix shutdown * Correct log level * Correctly measure dropped spans * Minor fixes * Move collection logic outside store * Store tests * Fix dropped items logic * Lint fixes * Fix flaky test * Unnest for clarity * Skip empty service name spans * Update changelog * Fmt * add more detail to migrating to new CRD names in v0.19.0 (#1028) * promtail update (#1020) * upgrade loki version * update kubernetes sd config in test * fix windows logger * update prometheus * update prometheus dependency to grafana/prometheus * remove commented replace * add changelog entry for primary dependency updates * comment on klog-gokit replace * remove weaveworks/common replace * get rid of forks with merged PRs * make crds * update changelog entry for prometheus * Remove duplicate wrapping of logger with component key (#1077) Signed-off-by: Christian Haudum <christian.haudum@gmail.com> * pkg/integrations: Add Ryan Geyer and Gabriel Antunes as code owners (#1075) * pkg/integrations: Add Ryan Geyer and Gabriel Antunes as code owners * update MAINTAINERS list * [Operator] Add Helm quickstart guide (#1079) * Add Helm quickstart guide * Update CHANGELOG.md * Remove trailing newlines * Update docs/operator/helm-getting-started.md Co-authored-by: Robert Fratto <robert.fratto@grafana.com> * Update docs/operator/helm-getting-started.md Co-authored-by: Robert Fratto <robert.fratto@grafana.com> * Update docs/operator/helm-getting-started.md Co-authored-by: Robert Fratto <robert.fratto@grafana.com> * Update docs/operator/helm-getting-started.md Co-authored-by: Robert Fratto <robert.fratto@grafana.com> * Update docs/operator/helm-getting-started.md Co-authored-by: Robert Fratto <robert.fratto@grafana.com> * Update docs/operator/helm-getting-started.md Co-authored-by: Robert Fratto <robert.fratto@grafana.com> * Update docs/operator/helm-getting-started.md Co-authored-by: Robert Fratto <robert.fratto@grafana.com> * Update docs/operator/helm-getting-started.md Co-authored-by: Robert Fratto <robert.fratto@grafana.com> * Review edits and link from production/README.md Co-authored-by: Robert Fratto <robert.fratto@grafana.com> * Exempt dev branches issues/PRs from staleness (#1083) * handle retrieve_config failures (#1085) * hack around dash not having pipefail * fix typo 🤦♂️ * remove cat * add comment * fix shellcheck issues * trap and send TERM sig in fatal * hide error message * Update go-kit logger package to remove debug logs (#1094) * Update github.com/go-kit/kit to v0.12.0 (#1090) * update github.com/go-kit/kit to v0.12.0 * node_exporter integration: fix build error on non-linux GOOS Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Reorg agent operator docs (#1100) * Reorg agent operator docs * Update CHANGELOG.md * Fix broken links in agent operator docs (#1101) * Fix `success_codes` logic and document new config options (#1076) * Document new options * Add tests and fix logic * Changelog * lint * Moar fixes * Remove noisy log * Ups, clean up println * Better naming * prepare for v0.21.0 release (#1106) * fix upgrade guide (#1107) * Fix parsePostgresURL issue (#1111) * Fix parsePostgresURL issue * Update Implementation and fix unit test * Add nolint and fix unit test * Update changelog * move changelog entry to unreleased Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Update version of temporary dnsmasq_exporter fork used (#1114) Fixes #1113 * Fix small issues in stats_exporter integration (#1092) * adding the logger to statsd exporter mapper * Updating changelog * Fixing typo in changelog * update statsd_exporter to include registry fix Fixes #1002 Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Default to using latest agent release version in operator (#1117) Fixes #1029 * docs: stop using the term "fully deprecated" (#1118) Prefer "removed" over "fully deprecated" Fixes #1000 * Update Promtail links to link to grafana.com/docs (#1115) * Don't create a WAL cleaner when there's no configured WAL directory. (#1119) This avoids noisy logs when someone uses the agent only for logs/traces. Fixes #735 * v0.21.1 release prep (#1120) * Setup CD for agent (#1103) * Setup CD for agent This deploys agent to dev on a merge to main. Depends on grafana/deployment_tools#19936 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Update config and drone hash Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Hopefully final changes Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Finally make it work! Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * fix relref link (#1123) * fix relref link * Update docs/scraping-service/_index.md Co-authored-by: Mario <mariorvinas@gmail.com> Co-authored-by: Mario <mariorvinas@gmail.com> * Fix typo (#1141) * Traces: Improved pod association in PromSD processor (#1137) * Improve k8s pod association * Add tests * Changelog * typo * Add prom_sd_pod_association * Extend tests for pod associations * Docs for pod association config * Lint fixes * Move to unreleased * Add instrumentation recommendations * Remove uncessary constants * Improve tests * remote config with http(s) provider (#1143) * sample remote config code with http provider * use t.TempDir() in unit test * no need to clean up after T.TempDir() * use NewClientFromConfig and make caller responsible for calling SetDirectory * handle nil HTTPClientConfig * remove blank identifier assignment * pass basic auth command line flags for remote config * address pr nits * add expiremental flag * set loader inline * update changelog * add remote config section in docs * pr comment updates * announce patch releases for cve-2021-41090 (#1152) * Merge patch release to main (#1153) * Add secret type to sensitive values * Break out config tests to their own implementation. Also remove username has a sensitive value. * Update changelog * Fix failing test * Scrub secrets when marshaling instance configs * update for v0.21 * Updated changes from the merge. * Remove changelog * Scrub out receivers has ***receivers_scrubber***:null * obscure etcd/consul credentials * Update pkg/traces/config_test.go Co-authored-by: Robert Fratto <robert.fratto@grafana.com> * Update pkg/config/config.go * go fmt * Change to using custom object and return <secret> * Fix bad merge * [v0.21.2] toggle config endpoint (#19) * disable /-/config endpoint by default * disable scraping api get endpoint as well * fix new test * add test and rename flag Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Update version to v0.21.2 * Update defaults.go * fix /-/config endpoint * also fix non-pointer config bug * temporarily disable linting for release * fix lint errors Co-authored-by: Matt Durham <mattdurham@ppog.org> Co-authored-by: Robert Lankford <robert.lankford@grafana.com> * Fix POSTGRES_EXPORTER_DATA_SOURCE_NAME usage for postgres_exporter (#1162) * Fix POSTGRES_EXPORTER_DATA_SOURCE_NAME usage for postgres_exporter A recent change broke the usage of POSTGRES_EXPORTER_DATA_SOURCE_NAME for the postgres_exporter. As the incorrect variable was checked in the if clause, it always raises an error. * changelog: keep feature -> enhancement -> bugfix order * postgres_exporter: add regression test Co-authored-by: f11r <f11r@users.noreply.github.com> Co-authored-by: Robert Fratto <robertfratto@gmail.com> Co-authored-by: kgeckhart <kgeckhart@users.noreply.github.com> Co-authored-by: mattdurham <mattdurham@ppog.org> Co-authored-by: Mario <mariorvinas@gmail.com> Co-authored-by: Cristian Greco <cristian@regolo.cc> Co-authored-by: Robby Milo <robby.milo@grafana.com> Co-authored-by: James Callahan <35791147+james-callahan@users.noreply.github.com> Co-authored-by: aengusrooneygrafana <54800912+aengusrooneygrafana@users.noreply.github.com> Co-authored-by: Alexey Murz Korepov <murznn@gmail.com> Co-authored-by: gaantunes <g.amaral.antunes@gmail.com> Co-authored-by: Florian Klink <flokli@flokli.de> Co-authored-by: Joseph Woodward <josephwoodward@xeuse.com> Co-authored-by: Bruce Mitchener <bruce.mitchener@gmail.com> Co-authored-by: nicoche <78445450+nicoche@users.noreply.github.com> Co-authored-by: Aaron Layfield <Aaron.Layfield@gmail.com> Co-authored-by: Michele Mancioppi <michele.mancioppi@canonical.com> Co-authored-by: Lucas Heinlen <lucas.heinlen@gmail.com> Co-authored-by: Robert Lankford <rlankfo@gmail.com> Co-authored-by: Bryan Boreham <bjboreham@gmail.com> Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com> Co-authored-by: Simon Crute <simonc6372@users.noreply.github.com> Co-authored-by: Ryan Geyer <me@ryangeyer.com> Co-authored-by: hanif <hjet@users.noreply.github.com> Co-authored-by: shturman <s.s.koshel@gmail.com> Co-authored-by: Robert Lankford <robert.lankford@grafana.com> Co-authored-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Mario <mario.rodriguez@grafana.com> Co-authored-by: Dharma Saputra <mail.dharma.saputra@gmail.com> Co-authored-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com> Co-authored-by: f11r <fiete.gruenter@rwth-aachen.de> Co-authored-by: f11r <f11r@users.noreply.github.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Right now if you want to ignore the error for a delete of a config which does not exist you have to do some error string checking. This adjusts the behavior in the config API to 404 instead of 400 when attempting to get or delete a non-existent config.
It's possible to get a 404 from all endpoints if there's no configstore configured which makes sense. It's also possible to get a 404 if there's no connection to the config store. This one feels like it might be a 500 instead of 404 since it seems to indicate a config/system issue vs no config store at all like the other 404. I can't tell if it's purely a safety check or possible to configure the agent in a certain way to hit it though.
Which issue(s) this PR fixes
N/A
Notes to the Reviewer
N/A
PR Checklist