Fix Query Builder FilterEditor on Alert Rules page #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpencerTorres
requested review from
asimpson,
bossinc,
aangelisc and
alyssajoyner
|
updated 😎 |
adamyeats
previously approved these changes
May 23, 2024
SpencerTorres
dismissed
adamyeats’s stale review
The merge-base changed after approval.
adamyeats
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #828
Dropdown wasn't working because
filter.operatorwas marked as readonly. I assume there's some magic going on within Grafana to where this code is interpreted differently on this page compared to the regular explore/dashboard view.It is a valid problem though, the current state was being mutated to generate the next state. Fixed by copying the filter and then modifying. Dropdown now works as expected on Alert Rules page.