feat(go): let multiple stabilisation steps share reruns #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🐳 Docker image built and pushed to GitHub Container Registry. You can pull it using: # For the Node.js server:
docker pull ghcr.io/grafana/grafana-image-renderer:dev-pull-787-8261106e16423646e275e33dd55c4a376a549c58
# For the Go server:
docker pull ghcr.io/grafana/grafana-image-renderer:dev-pull-787-8261106e16423646e275e33dd55c4a376a549c58-golangWarning This is a development image and should not be used in production. |
tskarhed
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep having flaky tests, showing that general server CPUs (which have lower single- & few-core performance than the CPU I use to develop) generally do not perform well enough with Chromium. This manifests for us in flaky tests, and would in practice also result in poor results for customers' reports.
In order to battle this, we'll stop waiting for each stabilisation step in order, to requiring them all to be true at once. This also adds more steps: we will now wait for queries, network requests, AND the HTML DOM to stabilise.
This does not solve the problem fully -- it is not possible to properly, fully solve. We have to strike a balance in finding "the right time" to do a print; this is the entire problem, and we've been too eager to print up until this change.