-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update release action to auto release kustomize yaml's as assets #1371
Conversation
feel free to add the release text generator you use so get the correct message directly in the draft, did not find the reference what is used in the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Links2004 for taking a stab at this.
Added a few comments.
It would be nice to include the CRDs as a separate bundle. This, since helm can't handle CRD updates through helm install
.
But I can handle that part if you don't feel like it.
It would also be nice to add some basic documentation about how to use the new Kustomize artifacts to install it to a cluster.
Added some docu, links are manually created and work(TM) with the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update, I added a minor comment, I will try to get time to verify the release processes later today.
kind: CustomResourceDefinition | ||
metadata: | ||
annotations: | ||
argocd.argoproj.io/sync-options: Replace=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally use server side apply instead of replace.
metadata:
annotations:
argocd.argoproj.io/sync-options: ServerSideApply=true
This way the kubectl.kubernetes.io/last-applied-configuration
isn't created and the CRD don't get too big.
But I guess this is individual, maybe we should provide both suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it on my own
It seems to be working as expected. It might be some issue with |
Signed-off-by: Edvin Norling <edvin.norling@kognic.com>
this change will add kustomize yamls to the release as assets and create a draft release.
by doing this it is possible to simply use:
this will not need any OCI support and allow easy usage with kustomize or kubectl.
see: #1367
example run: https://github.com/Links2004/grafana-operator/actions/runs/7408779579/job/20157697759
example release: https://github.com/Links2004/grafana-operator/releases/tag/t5.0.9