-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InfluxDB: Add configuration option for enabling insecure gRPC connections #83834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look fine to me.
Just to add to this. I'm using an Internal CA to sign my TLS/SSL certs and I am getting the following error.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It looks great.
Just a few nits.
After that it is good to go.
public/app/plugins/datasource/influxdb/components/editor/config/InfluxSQLConfig.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/influxdb/components/editor/config/InfluxSQLConfig.tsx
Outdated
Show resolved
Hide resolved
@itsmylife thanks for the review! I've applied the suggestions you made. Much appreciated |
Could you please run
and commit the changes you'll get? |
Done! |
There was a problem in |
Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
0ac7742
to
54765df
Compare
No problem! Rebased now. |
@jmickey Thank you for the PR and all the hustle you went through. 💪 |
It is not clear to me whether this was released with |
@hiltontj This is released in |
What is this feature?
Adds an option in the
SQL
query language configuration for InfluxDB to skip TLS security on gRPC connections for Flight SQL.Why do we need this feature?
InfluxData offers a Kubernetes deployment of V3 called "Clustered", when deployed alongside Grafana and using AWS LoadBalancers to terminate TLS attempting to connect to the cluster service endpoint for InfluxDB fails due to a lack of TLS connection when using the "SQL" Query Language type.
Who is this feature for?
InfluxDB v3 Clustered users.
Which issue(s) does this PR fix?:
Fixes #83732
Special notes for your reviewer:
Please check that: