Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB: Add configuration option for enabling insecure gRPC connections #83834

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

jmickey
Copy link
Contributor

@jmickey jmickey commented Mar 4, 2024

What is this feature?

Adds an option in the SQL query language configuration for InfluxDB to skip TLS security on gRPC connections for Flight SQL.

Why do we need this feature?

InfluxData offers a Kubernetes deployment of V3 called "Clustered", when deployed alongside Grafana and using AWS LoadBalancers to terminate TLS attempting to connect to the cluster service endpoint for InfluxDB fails due to a lack of TLS connection when using the "SQL" Query Language type.

Who is this feature for?

InfluxDB v3 Clustered users.

Which issue(s) does this PR fix?:

Fixes #83732

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@jmickey jmickey requested review from a team and jdbaldry as code owners March 4, 2024 14:45
@CLAassistant
Copy link

CLAassistant commented Mar 4, 2024

CLA assistant check
All committers have signed the CLA.

@grafana-pr-automation grafana-pr-automation bot added area/frontend type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project datasource/InfluxDB pr/external This PR is from external contributor area/backend labels Mar 4, 2024
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look fine to me.

@Abhi94N
Copy link

Abhi94N commented Mar 8, 2024

Just to add to this. I'm using an Internal CA to sign my TLS/SSL certs and I am getting the following error.

ERROR: flightsql: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: tls: failed to verify certificate: x509: certificate signed by unknown authority"

Copy link
Contributor

@itsmylife itsmylife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It looks great.
Just a few nits.
After that it is good to go.

@jmickey
Copy link
Contributor Author

jmickey commented Mar 11, 2024

@itsmylife thanks for the review! I've applied the suggestions you made. Much appreciated

@itsmylife itsmylife added this to the 11.0.x milestone Mar 11, 2024
@itsmylife itsmylife changed the title InfluxDB: add configuration option for enabling insecure gRPC connections InfluxDB: Add configuration option for enabling insecure gRPC connections Mar 11, 2024
@itsmylife itsmylife self-requested a review March 11, 2024 21:57
@itsmylife
Copy link
Contributor

Could you please run

  • yarn run prettier:checkDocs
  • yarn run prettier:write

and commit the changes you'll get?

@jmickey
Copy link
Contributor Author

jmickey commented Mar 12, 2024

Done!

@itsmylife
Copy link
Contributor

There was a problem in main. That was causing one test to fail always. We've fixed it. Could you please pull the latest main and merge into your branch? And then hopefully I will be able to merge this one. Thanks for that tin advance!

@jmickey
Copy link
Contributor Author

jmickey commented Mar 12, 2024

No problem! Rebased now.

@jdbaldry jdbaldry enabled auto-merge (squash) March 12, 2024 12:18
@jdbaldry jdbaldry disabled auto-merge March 12, 2024 12:18
@itsmylife itsmylife merged commit 297d73a into grafana:main Mar 12, 2024
13 checks passed
@itsmylife
Copy link
Contributor

@jmickey Thank you for the PR and all the hustle you went through. 💪

@hiltontj
Copy link

It is not clear to me whether this was released with 11.0.0. I do not see it on the release page for the v11.0.0 tag, but I do see the changes on the version associated with the v11.0.0 tag.

@itsmylife
Copy link
Contributor

@hiltontj This is released in v11.0.0 but somehow in the release page it wasn't mentioned. I am not sure what happened there bu this is in v11.0.0. Let me know if there is something else and I'd be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/backend area/frontend datasource/InfluxDB no-backport Skip backport of PR pr/external This PR is from external contributor type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InfluxDB-SQL: Allow Insecure gRPC
7 participants