Panel: Show multiple errors info in the inspector #64340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
requested review from
tskarhed,
ashharrison90,
axelavargas,
polibb and
leventebalogh
and removed request for
a team
andresmgot
added
no-backport
|
Backend code coverage report for PR #64340 |
|
Frontend code coverage report for PR #64340
|
public/app/features/dashboard/dashgrid/PanelHeader/PanelHeaderCorner.tsx
Outdated
Show resolved
Hide resolved
| return null; | ||
| } | ||
| if (errors.length === 1) { | ||
| return renderError(errors[0]); |
There was a problem hiding this comment.
What's the reason behind rendering a single error slightly differently (not wrapping it with an <Alert>)?
There was a problem hiding this comment.
I didn't want to affect the current style since for one error it's clear that all the content belong to the same error. For multiple errors, the best way I found to encasulate them separately was to show different Alerts. Happy to suggestions if there is something else I could try!
public/app/features/dashboard/dashgrid/PanelHeader/PanelHeader.tsx
Outdated
Show resolved
Hide resolved
leventebalogh
approved these changes
Mar 8, 2023
axelavargas
reviewed
Mar 8, 2023
|
Also covered now the new panel header:
|
andresmgot
added
add to changelog
and removed
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
The goal of this PR is to show the details of the errors in case a query with multiple targets fails more than once. Before, only the first error was shown in the panel title error and in the inspector. Now, in case there are multiple errors, only that is stated in the title error. Clicking on it displays the query inspector, in the Error tab which shows information about all the errors.
This also includes information about the status code in the error message (which was missing before):
Screencast.from.07-03-23.16.51.56.webm
Since the error could have different formats (e.g. including a json). This is how it looks for the different formats:
Why do we need this feature?
To display all the information available to the user about an error.
Who is this feature for?
Grafana users.
Which issue(s) does this PR fix?:
Fixes #54665
Fixes #58637
Special notes for your reviewer:
This supersedes #64022