-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Add CustomDetails field in PagerDuty contact point #64860
Merged
santihernandezc
merged 7 commits into
main
from
santihernandezc/add_custom_details_to_pagerduty
Mar 29, 2023
Merged
Alerting: Add CustomDetails field in PagerDuty contact point #64860
santihernandezc
merged 7 commits into
main
from
santihernandezc/add_custom_details_to_pagerduty
Mar 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santihernandezc
added
area/alerting
Grafana Alerting
add to changelog
no-backport
Skip backport of PR
labels
Mar 15, 2023
santihernandezc
requested review from
sakjur,
papagian and
suntala
and removed request for
a team
March 15, 2023 22:16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tested and everything works as expected. Please address my comment in receivers.go.
yuri-tceretian
added
the
area/alerting/notifications
Issues when sending alert notifications
label
Mar 15, 2023
grafanabot
added
the
type/docs
Flags the technical writing team for documentation support; auto adds to org-wide docs project
label
Mar 17, 2023
brendamuir
reviewed
Mar 21, 2023
docs/sources/alerting/manage-notifications/manage-contact-points/configure-notifiers.md
Outdated
Show resolved
Hide resolved
docs/sources/alerting/manage-notifications/manage-contact-points/configure-notifiers.md
Outdated
Show resolved
Hide resolved
docs/sources/alerting/manage-notifications/manage-contact-points/configure-notifiers.md
Outdated
Show resolved
Hide resolved
docs/sources/alerting/manage-notifications/manage-contact-points/configure-notifiers.md
Outdated
Show resolved
Hide resolved
docs/sources/alerting/manage-notifications/manage-contact-points/configure-notifiers.md
Outdated
Show resolved
Hide resolved
docs/sources/alerting/manage-notifications/manage-contact-points/configure-notifiers.md
Outdated
Show resolved
Hide resolved
docs/sources/alerting/manage-notifications/manage-contact-points/configure-notifiers.md
Outdated
Show resolved
Hide resolved
…ernandezc/add_custom_details_to_pagerduty
santihernandezc
commented
Mar 28, 2023
docs/sources/alerting/manage-notifications/manage-contact-points/_index.md
Show resolved
Hide resolved
brendamuir
approved these changes
Mar 29, 2023
santihernandezc
deleted the
santihernandezc/add_custom_details_to_pagerduty
branch
March 29, 2023 13:35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/alerting/notifications
Issues when sending alert notifications
area/alerting
Grafana Alerting
area/backend
no-backport
Skip backport of PR
type/docs
Flags the technical writing team for documentation support; auto adds to org-wide docs project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
CustomDetails
in Grafana's PagerDuty notification channel. This field is an object containing arbitrary key-value pairs, currently available in external Alertmanagers but not when using Grafana's internal one.The details provided by the user get merged with the default ones we use to provide information about the notification. In case of duplicate keys, the user-defined details prevail.
This field is optional, and it uses the same UI elements we use in external Alertmanagers.
These values are rendered on PagerDuty as part of the notification details.
Related issue: #63604
Note: For this feature, we need functionality introduced in the latest commit (as of now) of the
grafana/alerting
package, hence the update ingo.mod
andgo.sum