Loki: Replace pre-calculated $__interval values for backend interpolation #79697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domasx2
added
datasource/Loki
area/datasource/frontend
no-backport
matyax
approved these changes
Dec 19, 2023
|
@torkelo @dprokop is this still relevant then given grafana/scenes#508 fix? |
dprokop
approved these changes
Dec 19, 2023
domasx2
force-pushed
the
domas-loki-interval-interpolation
branch
from
1582c49
to
5e27b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR to #79645.
Need to have
$__intervaland$__interval_msinscopedVarsfor Scenes to no-op interpolate them instead of usingTimeMacroand in some cases resolving to empty string.Related: grafana/scenes#507