Prometheus: Add native histogram functions #86002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohandley
added
datasource/Prometheus
add to changelog
no-backport
itsmylife
approved these changes
Apr 15, 2024
itsmylife
reviewed
Apr 15, 2024
Comment on lines
293
to
314
| it('parses a native histogram function correctly', () => { | ||
| expect( | ||
| buildVisualQueryFromString('histogram_count(rate(counters_logins{app="backend"}[$__rate_interval]))') | ||
| ).toEqual({ | ||
| errors: [], | ||
| query: { | ||
| metric: 'counters_logins', | ||
| labels: [{ label: 'app', op: '=', value: 'backend' }], | ||
| operations: [ | ||
| { | ||
| id: 'rate', | ||
| params: ['$__rate_interval'], | ||
| }, | ||
| { | ||
| id: 'histogram_quantile', | ||
| }, | ||
| ], | ||
| }, | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This will always fail because lezer-promqlv0.37.0-rc.1 has no idea about new histogram functions. So you can skip it and I'll enable it in my PR
There was a problem hiding this comment.
I just tried your changes on my PR and it works!
Screen.Recording.2024-04-15.at.19.09.03.mov
There was a problem hiding this comment.
Of course there is no graph available because the metric I used is not native histogram. I picked it just for the sake of the demo.
There was a problem hiding this comment.
Yes! I wrote it just to have a test ready for when we do get it in. I will remove it and you can add it to your PR. Go Lezer parser update!!! Great job Ismail!!! 🏆
There was a problem hiding this comment.
I would say don't remove it. But just mark it to skip. You can define it as
xit('parses a native... so it will be ignored
^^^___________________________________
bohandley
force-pushed
the
bohandley/add-native-histogram-functions
branch
from
2f6e666
to
d13a5b7
Compare
xlson
added a commit
that referenced
this pull request
Apr 16, 2024
* main: (482 commits) I18N: Split loadTranslations i18next plugin into seperate file (#86217) Grafana UI: `StackingEditor` and `addHideFrom` - Replace `HorizontalGroup` with `Stack` (#86192) Dashboard: Migration - Add public dashboard tag in the nav bar (#86204) mssql: decouple sqleng (#86130) Docs: Fix typos (#85651) Playlists: Enable kubernetesPlaylists by default in OSS (#86259) DashboardScene: Fixes saving dashboard with angular panels (#86098) DashboardScene: Fix empty row repeat issue (#86095) Prometheus: Use the frontend package in Prometheus and remove feature toggle (#86080) docs: add annotations play link (#86206) Chore: add missing modowner (#86234) docs: add thresholds play link (#86212) docs: added logs panel play link; added dedup options, reformatted fig (#86209) docs: query data/relative time range override play link (#86213) Docs: added bar gauge play link (#86205) Docs: add template var Play link; cleanup existing (#86074) Prometheus: Add native histogram functions (#86002) K8s: add ID token to requests outbound to new query endpoint (#86214) Prometheus: Respect dashboard queries when querying ad hoc filter labels (#85674) Chore: Use `handleReducedMotion` to smooth the animation in `LoadingBar` (#85808) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76111
Be aware!!!
These functions will not parse correctly when switching from code editor. This won't work until the
@prometheus-io/lezer-promqlis updated here.This adds functions for Prometheus native histograms. It provides auto complete for the following functions:
Please check that: