mssql: decouple sqleng #86130
Merged
mssql: decouple sqleng #86130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor
requested review from
asimpson,
bossinc,
aangelisc,
adamyeats,
yesoreyeram,
zoltanbedi and
gwdawson
and removed request for
a team,
yesoreyeram,
zoltanbedi and
gwdawson
grafana-pr-automation
bot
added
datasource/MSSQL
xlson
added a commit
that referenced
this pull request
Apr 16, 2024
* main: (482 commits) I18N: Split loadTranslations i18next plugin into seperate file (#86217) Grafana UI: `StackingEditor` and `addHideFrom` - Replace `HorizontalGroup` with `Stack` (#86192) Dashboard: Migration - Add public dashboard tag in the nav bar (#86204) mssql: decouple sqleng (#86130) Docs: Fix typos (#85651) Playlists: Enable kubernetesPlaylists by default in OSS (#86259) DashboardScene: Fixes saving dashboard with angular panels (#86098) DashboardScene: Fix empty row repeat issue (#86095) Prometheus: Use the frontend package in Prometheus and remove feature toggle (#86080) docs: add annotations play link (#86206) Chore: add missing modowner (#86234) docs: add thresholds play link (#86212) docs: added logs panel play link; added dedup options, reformatted fig (#86209) docs: query data/relative time range override play link (#86213) Docs: added bar gauge play link (#86205) Docs: add template var Play link; cleanup existing (#86074) Prometheus: Add native histogram functions (#86002) K8s: add ID token to requests outbound to new query endpoint (#86214) Prometheus: Respect dashboard queries when querying ad hoc filter labels (#85674) Chore: Use `handleReducedMotion` to smooth the animation in `LoadingBar` (#85808) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
pkg/tsdb/sqlengpackage was used bypostgres&mssql&mysql. to resolve this, we will copy the file into all 3 datasources.we already added copies to
mysqland topostgres, this final PR moves the folder tomssql.NOTE: i wanted the PR to be the simplest possible, so it literally only moves the files and adjusts the imports. a lot of simplification is possible in the future, but i did not want to complicate this PR with that.