Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add annotations play link #86206

Merged
merged 2 commits into from
Apr 15, 2024
Merged

docs: add annotations play link #86206

merged 2 commits into from
Apr 15, 2024

Conversation

moxious
Copy link
Contributor

@moxious moxious commented Apr 15, 2024

part of a series of PRs

@moxious moxious added type/docs no-changelog Skip including change in changelog/release notes backport v10.2.x backport v10.3.x Mark PR for automatic backport to v10.3.x backport v10.4.x backport v11.0.x Mark PR for automatic backport to v11.0.x labels Apr 15, 2024
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 15, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

4 similar comments
Copy link
Contributor

This PR must be merged before a backport PR will be created.

Copy link
Contributor

This PR must be merged before a backport PR will be created.

Copy link
Contributor

This PR must be merged before a backport PR will be created.

Copy link
Contributor

This PR must be merged before a backport PR will be created.

Copy link
Collaborator

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I actually think you should move this either up to after the main image or down to to after line 37 or 43. As it is, the shortcode separates the bullet list above it from the explanation of the bullet list below it. I'm just gonna do a request changes on this one so it doesn't accidentally get merged.

@imatwawana imatwawana merged commit c9350a2 into main Apr 15, 2024
11 checks passed
@imatwawana imatwawana deleted the moxious-patch-annotations branch April 15, 2024 21:30
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 15, 2024
* docs: add annotations play link

* PR feedback

(cherry picked from commit c9350a2)
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 15, 2024
* docs: add annotations play link

* PR feedback

(cherry picked from commit c9350a2)
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 15, 2024
* docs: add annotations play link

* PR feedback

(cherry picked from commit c9350a2)
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 15, 2024
* docs: add annotations play link

* PR feedback

(cherry picked from commit c9350a2)
imatwawana pushed a commit that referenced this pull request Apr 15, 2024
docs: add annotations play link (#86206)

* docs: add annotations play link

* PR feedback

(cherry picked from commit c9350a2)

Co-authored-by: David Allen <david.allen@grafana.com>
imatwawana pushed a commit that referenced this pull request Apr 15, 2024
docs: add annotations play link (#86206)

* docs: add annotations play link

* PR feedback

(cherry picked from commit c9350a2)

Co-authored-by: David Allen <david.allen@grafana.com>
imatwawana pushed a commit that referenced this pull request Apr 15, 2024
docs: add annotations play link (#86206)

* docs: add annotations play link

* PR feedback

(cherry picked from commit c9350a2)

Co-authored-by: David Allen <david.allen@grafana.com>
imatwawana pushed a commit that referenced this pull request Apr 15, 2024
docs: add annotations play link (#86206)

* docs: add annotations play link

* PR feedback

(cherry picked from commit c9350a2)

Co-authored-by: David Allen <david.allen@grafana.com>
xlson added a commit that referenced this pull request Apr 16, 2024
* main: (482 commits)
  I18N: Split loadTranslations i18next plugin into seperate file (#86217)
  Grafana UI: `StackingEditor` and `addHideFrom` - Replace `HorizontalGroup` with `Stack` (#86192)
  Dashboard: Migration -  Add public dashboard tag in the nav bar (#86204)
  mssql: decouple sqleng (#86130)
  Docs: Fix typos (#85651)
  Playlists: Enable kubernetesPlaylists by default in OSS (#86259)
  DashboardScene: Fixes saving dashboard with angular panels  (#86098)
  DashboardScene: Fix empty row repeat issue (#86095)
  Prometheus: Use the frontend package in Prometheus and remove feature toggle (#86080)
  docs: add annotations play link (#86206)
  Chore: add missing modowner (#86234)
  docs: add thresholds play link (#86212)
  docs: added logs panel play link; added dedup options, reformatted fig (#86209)
  docs: query data/relative time range override play link (#86213)
  Docs: added bar gauge play link (#86205)
  Docs: add template var Play link; cleanup existing (#86074)
  Prometheus: Add native histogram functions (#86002)
  K8s: add ID token to requests outbound to new query endpoint (#86214)
  Prometheus: Respect dashboard queries when querying ad hoc filter labels (#85674)
  Chore: Use `handleReducedMotion` to smooth the animation in `LoadingBar` (#85808)
  ...
@kevinwcyu kevinwcyu modified the milestones: 11.1.x, 11.1.0 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v10.2.x backport v10.3.x Mark PR for automatic backport to v10.3.x backport v10.4.x backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants