-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add annotations play link #86206
Conversation
This PR must be merged before a backport PR will be created. |
4 similar comments
This PR must be merged before a backport PR will be created. |
This PR must be merged before a backport PR will be created. |
This PR must be merged before a backport PR will be created. |
This PR must be merged before a backport PR will be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I actually think you should move this either up to after the main image or down to to after line 37 or 43. As it is, the shortcode separates the bullet list above it from the explanation of the bullet list below it. I'm just gonna do a request changes on this one so it doesn't accidentally get merged.
* docs: add annotations play link * PR feedback (cherry picked from commit c9350a2)
* docs: add annotations play link * PR feedback (cherry picked from commit c9350a2)
* docs: add annotations play link * PR feedback (cherry picked from commit c9350a2)
* docs: add annotations play link * PR feedback (cherry picked from commit c9350a2)
* main: (482 commits) I18N: Split loadTranslations i18next plugin into seperate file (#86217) Grafana UI: `StackingEditor` and `addHideFrom` - Replace `HorizontalGroup` with `Stack` (#86192) Dashboard: Migration - Add public dashboard tag in the nav bar (#86204) mssql: decouple sqleng (#86130) Docs: Fix typos (#85651) Playlists: Enable kubernetesPlaylists by default in OSS (#86259) DashboardScene: Fixes saving dashboard with angular panels (#86098) DashboardScene: Fix empty row repeat issue (#86095) Prometheus: Use the frontend package in Prometheus and remove feature toggle (#86080) docs: add annotations play link (#86206) Chore: add missing modowner (#86234) docs: add thresholds play link (#86212) docs: added logs panel play link; added dedup options, reformatted fig (#86209) docs: query data/relative time range override play link (#86213) Docs: added bar gauge play link (#86205) Docs: add template var Play link; cleanup existing (#86074) Prometheus: Add native histogram functions (#86002) K8s: add ID token to requests outbound to new query endpoint (#86214) Prometheus: Respect dashboard queries when querying ad hoc filter labels (#85674) Chore: Use `handleReducedMotion` to smooth the animation in `LoadingBar` (#85808) ...
part of a series of PRs