Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: ForgottenPassword - Replace HorizontalGroup with Stack #86393

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Chore: ForgottenPassword - Replace HorizontalGroup with Stack #86393

merged 1 commit into from
Apr 17, 2024

Conversation

eledobleefe
Copy link
Contributor

What is this feature?
This is part of the epic #85510

Why do we need this feature?
To replace deprecated layout components with new ones.

Who is this feature for?
Everybody

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:
Before:
Captura de pantalla 2024-04-16 a las 21 08 05

After:
Captura de pantalla 2024-04-16 a las 21 10 01

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@eledobleefe eledobleefe added area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Apr 16, 2024
@eledobleefe eledobleefe added this to the 11.1.x milestone Apr 16, 2024
@eledobleefe eledobleefe self-assigned this Apr 16, 2024
@eledobleefe eledobleefe requested review from grafanabot and a team as code owners April 16, 2024 19:20
@eledobleefe eledobleefe requested review from joshhunt and L-M-K-B and removed request for a team April 16, 2024 19:20
@eledobleefe eledobleefe mentioned this pull request Apr 16, 2024
Open
43 tasks
ashharrison90
ashharrison90 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@eledobleefe eledobleefe merged commit 6a5bdca into main Apr 17, 2024
24 checks passed
@eledobleefe eledobleefe deleted the eledobleefe/deprecated-layout-forgotten-password branch April 17, 2024 09:51
@kevinwcyu kevinwcyu modified the milestones: 11.1.x, 11.1.0 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashharrison90 ashharrison90 ashharrison90 approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@L-M-K-B L-M-K-B Awaiting requested review from L-M-K-B L-M-K-B is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees

@eledobleefe eledobleefe

Labels
area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
Grafana Frontend Platform
Status: 🚀 Done
Milestone
11.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eledobleefe @ashharrison90 @kevinwcyu