Frontend: Improve barrel file detection in codemod #87389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
area/frontend
type/debt
leventebalogh
approved these changes
May 8, 2024
jackw
force-pushed
the
jackw/fix-barrel-imports-codemod
branch
from
3be18ae
to
901f045
Compare
…nt in barrel-imports script
jackw
force-pushed
the
jackw/fix-barrel-imports-codemod
branch
from
901f045
to
8360e71
Compare
obetomuniz
added a commit
that referenced
this pull request
May 9, 2024
…-tracker * gops-configuration-tracker: (51 commits) Reorganize hooks into separate folders/files for each app add aria and properties role for Progressbar Address pr review comments part1 Update dependency @opentelemetry/semantic-conventions to v1.24.1 (#87544) update test Update dependency @grafana/scenes to v4.17.2 fix logic behind default contact point check new yarn version Update Yarn to v4.2.2 remove unnecessary AlertmanagerProvider alerting: integrations > small update (#87538) RBAC: Adding action set resolver for RBAC evaluation (#86801) Frontend: Improve barrel file detection in codemod (#87389) Unified Storage: Add SQL template package (#87524) Sql Expressions: use display name for sql tables (#87530) Azure Monitor: Update grafana-azure-sdk-go to v2.0.3 (#87480) Timeseries: Fix incorrect threshold style (#87521) GRPC Server: Add README (#87442) Ephemeral instances: update go version (#87526) Scopes: Add a /find query endpoint (#87457) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR improves detection of barrel file imports in our codebase.
Why do we need this feature?
To improve the health of our frontend codebase. Prior to the changes in this PR the codemod only identified / modded ~360 files. By using require.resolve, filtering out bare specifiers and resolving
app/import paths that number creeps up to 1145 files.Who is this feature for?
Grafana developers
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: