Devenv: Allow configuring alertmanager config for prometheus docker block #89558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillesdemey
changed the title
gillesdemey
commented
Jun 21, 2024
| volumes: | ||
| - ${PWD}/docker/blocks/prometheus/alertmanager.yml:/etc/alertmanager/alertmanager.yml | ||
| command: > | ||
| --config.file=/etc/alertmanager/alertmanager.yml |
There was a problem hiding this comment.
technically not necessary as this is the default path defined in the Dockerfile for the image but I prefer explicit commands instead of having to dig around in the upstream dockerfiles
tomratcliffe
approved these changes
Jun 21, 2024
|
We can follow-up with a kitchen-sink example 👍 |
gillesdemey
added
the
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR allows configuration of the Alertmanager in the Prometheus docker block.
The default config is taken from the ha example as per the default Alertmanager image.