Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tanka dependency #348

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

malcolmholmes
Copy link
Contributor

A previous PR removed Grizzly's dependency on Tanka for walking a tree seeking out
resources. The only remaining Tanka dependency is native functions. Most are now in
the standard lib, so native funcs are no longer required. Three are still needed, so
this PR adds them directly to Grizzly.

@malcolmholmes malcolmholmes requested a review from a team as a code owner February 23, 2024 15:30
@julienduchesne
Copy link
Member

Needs to be rebased

@julienduchesne julienduchesne removed the request for review from a team February 26, 2024 12:42
@malcolmholmes malcolmholmes force-pushed the malcolmholmes/remove-tanka-dependency branch from f991a11 to 720448f Compare February 27, 2024 12:43
@malcolmholmes malcolmholmes requested a review from a team February 27, 2024 21:42
pkg/grizzly/jsonnet.go Outdated Show resolved Hide resolved
@malcolmholmes malcolmholmes merged commit 31989c0 into main Feb 29, 2024
7 checks passed
@malcolmholmes malcolmholmes deleted the malcolmholmes/remove-tanka-dependency branch February 29, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants