Adds Mimir integration tests #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: malcolmholmes <42545407+malcolmholmes@users.noreply.github.com>
Co-authored-by: malcolmholmes <42545407+malcolmholmes@users.noreply.github.com>
malcolmholmes
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #415
It adds Mimir configuration to docker-compose and an two integration tests to send and retrieve the rules.
The test adds one ugly second of delay between tests because Mimir takes some time to sync the rules. Setting
poll_intervalto1sin rules configuration, speeds up the sync, but we still need this small delay to avoid 500 error responses.✅
Note: It could be nice have this #406 merged first to be able to add more use cases and use http client.