-
Notifications
You must be signed in to change notification settings - Fork 241
Update k6 browser's BrowserType.Connect documentation #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/1114/merge It will be deleted automatically in 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs! I left some suggestions for you to consider.
src/data/markdown/docs/30 k6-browser/02 API/03 BrowserType/connect--options--.md
Outdated
Show resolved
Hide resolved
src/data/markdown/docs/30 k6-browser/02 API/03 BrowserType/connect--options--.md
Outdated
Show resolved
Hide resolved
This commit updates the documentation for the k6 browser's BrowserType.Connect method by fixing the method signature and adding a dedicated page which documents the supported arguments and provides an example.
bd40809
to
b1fa39e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂
This commit updates the documentation for the k6 browser's BrowserType.Connect method by fixing the method signature and adding a dedicated page which documents the supported arguments and provides an example.
This commit updates the documentation for the k6 browser's BrowserType.Connect method by fixing the method signature and adding a dedicated page which documents the supported arguments and provides an example.
This commit updates the documentation for the k6 browser's BrowserType.Connect method by fixing the method signature and adding a dedicated page which documents the supported arguments and provides an example.
This PR updates the documentation for the k6 browser's
BrowserType.Connect
method by fixing the method signature and adding a dedicated page which documents the supported arguments and provides an example.Closes: #1112 .