Skip to content

Conversation

ka3de
Copy link
Contributor

@ka3de ka3de commented Apr 4, 2023

This PR updates the documentation for the k6 browser's BrowserType.Connect method by fixing the method signature and adding a dedicated page which documents the supported arguments and provides an example.

Closes: #1112 .

@ka3de ka3de self-assigned this Apr 4, 2023
@ka3de ka3de requested review from ankur22, inancgumus and mdcruz April 4, 2023 14:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1114/merge

It will be deleted automatically in 30 days.

Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs! I left some suggestions for you to consider.

This commit updates the documentation for the k6 browser's
BrowserType.Connect method by fixing the method signature and adding
a dedicated page which documents the supported arguments and provides an
example.
@ka3de ka3de force-pushed the update/1112-k6-browser-connect branch from bd40809 to b1fa39e Compare April 5, 2023 06:07
Copy link
Contributor

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@ka3de ka3de changed the base branch from main to update-k6-browser-docs April 17, 2023 11:47
@ka3de ka3de merged commit e2aebb4 into update-k6-browser-docs Apr 17, 2023
@ka3de ka3de deleted the update/1112-k6-browser-connect branch April 17, 2023 11:48
mdcruz pushed a commit that referenced this pull request Apr 18, 2023
This commit updates the documentation for the k6 browser's
BrowserType.Connect method by fixing the method signature and adding
a dedicated page which documents the supported arguments and provides an
example.
ka3de added a commit that referenced this pull request Apr 24, 2023
This commit updates the documentation for the k6 browser's
BrowserType.Connect method by fixing the method signature and adding
a dedicated page which documents the supported arguments and provides an
example.
ka3de added a commit that referenced this pull request Apr 24, 2023
This commit updates the documentation for the k6 browser's
BrowserType.Connect method by fixing the method signature and adding
a dedicated page which documents the supported arguments and provides an
example.
@inancgumus inancgumus added the Area: browser The browser module label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document k6 Browser BrowserType.Connect
4 participants