Skip to content

Conversation

oleiade
Copy link
Contributor

@oleiade oleiade commented Apr 6, 2023

This PR adds a dedicated documentation section for the newly introduced k6/experimental/webcrypto module.

This was a long-haul batch of work and is probably riddled with mistakes and forgotten information. Please don't hesitate to poke and provide feedback and requests for corrections.

Although the module is not 100% on par with the specification yet, I described only the supported methods and algorithms without outlining what was missing. If you think we should write it in a clearer way somewhere, please let me know.

PS: I took a lot of inspiration from the wording used on MDN, I'd like to credit them, but then I'd need to do it everywhere. What would be the canonical way to do that?

@oleiade oleiade self-assigned this Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1119/merge

It will be deleted automatically in 30 days.

Copy link
Contributor

@MattDodsonEnglish MattDodsonEnglish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The links create nice web that structurally supports the reference.

Approved with a bunch of random nits.

@mstoykov
Copy link
Contributor

Just a reminder that this should get merged after we start releasing the docs for v0.44 as this is a new API

oleiade and others added 10 commits April 14, 2023 10:26
… webcrypto.md

Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
… webcrypto.md

Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
… webcrypto/01 Crypto/01 getRandomValues.md

Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
… webcrypto/01 Crypto/02 randomUUID.md

Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
… webcrypto/02 SubtleCrypto.md

Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
… webcrypto/02 SubtleCrypto/01 decrypt.md

Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
… webcrypto/01 Crypto/01 getRandomValues.md

Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
… webcrypto/02 SubtleCrypto/01 decrypt.md

Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
… webcrypto.md

Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
@oleiade oleiade requested a review from codebien April 14, 2023 08:32
@oleiade oleiade merged commit 5513fdc into main Apr 24, 2023
@oleiade oleiade deleted the experimental/webcrypto branch April 24, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants