Skip to content

Conversation

381181295
Copy link

Fix incorrect file path in Docker setup instructions for k6, InfluxDB, and Grafana. Change the path from $PWD/samples to $PWD/examples to reflect the correct location of the es6sample.js file.

Fix incorrect file path in Docker setup instructions for k6, InfluxDB, and Grafana. Change the path from $PWD/samples to $PWD/examples to reflect the correct location of the es6sample.js file.
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@MattDodsonEnglish
Copy link
Contributor

MattDodsonEnglish commented May 15, 2023

Oh, now I see that this entire page has been refactored and that page no longer exists 😬 . I'm sorry to both of you for being late.

However this is a great callout, and it made me think about some other places where the docs may need to be fixed to update that samples dir.

MattDodsonEnglish added a commit that referenced this pull request May 15, 2023
Thanks to @ch4r-ch4r  for pointing this out in
#1143
@MattDodsonEnglish
Copy link
Contributor

Closing because the reference to that file seems to have disappeared. Still, thanks @ch4r-ch4r for pointing this out: it led to fixes on other pages.

2d2737b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants