Skip to content

Conversation

ppcano
Copy link
Collaborator

@ppcano ppcano commented May 15, 2023

Rewrite and restructure the current Recording a session documentation to suggest the Hybrid approach. Updates:

Create tests from recordings

@github-actions
Copy link
Contributor

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1177/merge

It will be deleted automatically in 30 days.

@ppcano ppcano changed the title WIP - Session recorder and hybrid performance Session recorder and hybrid performance May 16, 2023
@ppcano ppcano requested a review from mdcruz May 16, 2023 12:28
@mdcruz
Copy link
Contributor

mdcruz commented May 17, 2023

@ppcano

  1. Not part of this change but worth adding a link to the load-testing types in this paragraph.
Edit your script as necessary. Depending on the type of testing, you might need to change different aspects of the script. Typical changes are for [load options](https://mdr-ci.staging.k6.io/docs/refs/pull/1177/merge/using-k6/options) and to handle [correlation and dynamic data](https://mdr-ci.staging.k6.io/docs/refs/pull/1177/merge/examples/correlation-and-dynamic-data).

type of testing -> add a link to https://k6.io/docs/test-types/load-test-types/

  1. There is a broken link on Using the browser recorder guide. The HAR converter link is pointing to this 404 page -> https://mdr-ci.staging.k6.io/docs/refs/pull/1177/merge/test-authoring/recording-a-session/har-converter/

  2. There is a broken link on Using the HAR converter. The Browser recorder link is pointing to a 404 page -> https://mdr-ci.staging.k6.io/docs/refs/pull/1177/merge/test-authoring/recording-a-session/browser-recorder/

@ppcano
Copy link
Collaborator Author

ppcano commented May 17, 2023

@mdcruz the internal links are now fixed by 5d9e094

@ppcano ppcano requested a review from MattDodsonEnglish May 17, 2023 15:35
Copy link
Contributor

@MattDodsonEnglish MattDodsonEnglish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made small nits

Copy link
Contributor

@MattDodsonEnglish MattDodsonEnglish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made small nits

ppcano and others added 2 commits May 18, 2023 12:13
…eate tests from recordings.md

Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
…eate tests from recordings/01 Using the browser recorder.md

Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
@ppcano ppcano merged commit ee9a94a into main May 18, 2023
@ppcano ppcano deleted the session-recorder-and-hybrid-performance branch May 18, 2023 10:18
@inancgumus inancgumus added the Area: browser The browser module label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants