Skip to content

Conversation

nadiamoe
Copy link
Member

@nadiamoe nadiamoe commented May 22, 2023

As mentioned in #1183 (comment), and contrary to what I intended with #1182, the gatsby cache is not being currently reused across PRs. The reason why is outlined in the GHA docs:

Workflow runs cannot restore caches created for child branches or sibling branches. For example, a cache created for the child feature-b branch would not be accessible to a workflow run triggered on the parent main branch. Similarly, a cache created for the feature-a branch with the base main would not be accessible to its sibling feature-c branch with the base main.

An easy way to fix this is to also use the cache on workflows targeting main, such as the deploy to staging job. This will also make this workflow faster.

@nadiamoe nadiamoe changed the title ci/staging: leverage node_modules and gatsby output on staging as well ci/staging: leverage node_modules and gatsby cache on staging as well May 22, 2023
@nadiamoe nadiamoe force-pushed the gha-staging-cache branch from bec4fb0 to 6f9535f Compare May 22, 2023 11:08
@nadiamoe nadiamoe marked this pull request as ready for review May 22, 2023 11:08
@nadiamoe nadiamoe requested a review from imiric May 22, 2023 11:08
@github-actions
Copy link
Contributor

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1188/merge

It will be deleted automatically in 30 days.

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nadiamoe
Copy link
Member Author

Merging now, crossing fingers so I didn't make any stupid syntax mistake 🤞🏻

@nadiamoe nadiamoe merged commit c8309be into main May 22, 2023
@nadiamoe nadiamoe deleted the gha-staging-cache branch May 22, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants