feat: add extensions checkbox and link (#1190) #1193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add extensions checkbox and link * chore: remove extensions card link * chore: update extensions card link * chore: update extensions card link icon
✅ k6-docs-production deploy preview ready
|
|
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/1193/merge It will be deleted automatically in 30 days. |
|
Lmk @javaducky @ppcano on how exactly we are going to combine |
|
Hi @bolotskydev, I just returned from PTO but will be OOO for a conference this week. I'll take a look at this sometime this week and get back to you. |
|
Hey @javaducky, any updates on this? 👀 |
javaducky
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
@bolotskydev thank you for the nudge...sadly I forgot about this!
LGTM! Looks great, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add extensions checkbox and link
chore: remove extensions card link
chore: update extensions card link
chore: update extensions card link icon