-
Notifications
You must be signed in to change notification settings - Fork 241
Create guide for distributed tests #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
15920d6
to
68bf48d
Compare
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/1251/merge It will be deleted automatically in 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together, Paul!
For the "1st iteration" of the guide, I think it's pretty good: straight-forward and precise. I've only left a few small suggestions for improvements.
Overall, most noticeable is, of course, that not all options are being mentioned, e.g. LocalFile
or cleanup
. But probably adding everything here will make the guide quite unwieldy and hard to read through so it makes sense to keep it brief. I guess if at some point we could add a "k6-operator reference" page where we can keep a list of all supported options, that'd be a solution. OTOH, current Readme also contains things like "Multi-file tests" with k6 archive
suggestion: a very common question which is neither a part of API reference nor part of a guide. More like a "howto" or "k6-operator tricks"... Either way, 👍 to have a guide for now 😄
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Show resolved
Hide resolved
Absolutely. My goal is to have an operator section similar to what is available for the xk6-disruptor. A goal will be to provide architecture information, a comprehensive listing of options, and very specific usage examples. |
@yorugac, I pushed some updates. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javaducky, after more reading I've found a couple of typos and possible improvement suggestions - please see the comments. The most funny part is likely the "Custom Resource" terminology: it seems to me that even Kubernetes docs can be seen as confusing on the topic...
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/07 Testing Guides/05 Running distributed tests.md
Show resolved
Hide resolved
fdb4656
to
94e7053
Compare
@yorugac, here are some more updates as we discussed. |
Signed-off-by: Paul Balogh <javaducky@gmail.com>
Signed-off-by: Paul Balogh <javaducky@gmail.com>
Signed-off-by: Paul Balogh <javaducky@gmail.com>
Signed-off-by: Paul Balogh <javaducky@gmail.com>
94e7053
to
daa6923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subsections about PVC flow better now, IMHO. Though I wonder if we should pull volumes out completely as a separate guide some time and keep this guide simple, with only one "path of execution" via configmaps...
Overall, LGTM 🙌 Thanks for the updates!
This is not a comprehensive guide for all available options of the operator. We'll be expanding documentation for the operator in a new section at a later time.