Skip to content

Conversation

acuenca-facephi
Copy link
Contributor

xk6-read is an extension to read files and directories.
I created it because in my use case I need to use thousands of different images during test execution, and k6 only can read files in the init stage. This force me to load all the images using a JSON file with an array of file paths and load in memory ALL the images.

Add my xk6-read extension to extensions registry.
@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

@javaducky javaducky self-requested a review July 25, 2023 13:53
@javaducky
Copy link
Contributor

Hello @acuenca-facephi ! Thank you for your contribution.

After checking into the project, I was curious about the particular license selection of CC0-1.0. Checking into this particular type, there is some concern given that the Open Source Initiative still needs to approve the license. Would it be acceptable to change the license to Apache 2.0?

@acuenca-facephi
Copy link
Contributor Author

acuenca-facephi commented Jul 26, 2023

Hello @acuenca-facephi ! Thank you for your contribution.

After checking into the project, I was curious about the particular license selection of CC0-1.0. Checking into this particular type, there is some concern given that the Open Source Initiative still needs to approve the license. Would it be acceptable to change the license to Apache 2.0?

No problem, I updated the license to Apache 2.0.

Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much!

@javaducky javaducky merged commit 387de13 into grafana:main Jul 26, 2023
@acuenca-facephi acuenca-facephi deleted the patch-1 branch July 26, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants