Skip to content

Conversation

inancgumus
Copy link
Contributor

@inancgumus inancgumus commented Sep 19, 2023

Related: grafana/xk6-browser#6.

Updates: #1309

@inancgumus inancgumus marked this pull request as ready for review September 19, 2023 14:10
@inancgumus inancgumus self-assigned this Sep 19, 2023
@inancgumus inancgumus changed the title Add browser cookies Docs: Add browser cookies Sep 19, 2023
@inancgumus inancgumus added the Area: browser The browser module label Sep 19, 2023
@inancgumus inancgumus changed the title Docs: Add browser cookies Docs: Browser cookies Sep 19, 2023
Copy link
Contributor

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 👏
Just made some small suggestions.

@ka3de ka3de force-pushed the update/browser-v1.1.0 branch from fc93351 to 1f0ba33 Compare September 20, 2023 07:03
@inancgumus inancgumus requested a review from ka3de September 20, 2023 08:10
Copy link
Contributor

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM 🙂

Co-authored-by: Ankur Agarwal <ankur.agarwal@grafana.com>
@inancgumus inancgumus requested a review from ankur22 September 20, 2023 09:50
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus merged commit c569db7 into update/browser-v1.1.0 Sep 20, 2023
@inancgumus inancgumus deleted the add/browser-cookies branch September 20, 2023 10:03
inancgumus added a commit that referenced this pull request Sep 20, 2023
inancgumus added a commit that referenced this pull request Sep 20, 2023
ka3de pushed a commit that referenced this pull request Sep 27, 2023
ka3de pushed a commit that referenced this pull request Sep 27, 2023
ka3de pushed a commit that referenced this pull request Oct 9, 2023
ka3de pushed a commit that referenced this pull request Oct 9, 2023
ka3de pushed a commit that referenced this pull request Oct 9, 2023
ka3de pushed a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants