Update metric name restrictions #1331
Conversation
Changes in code done in grafana/k6#3335
|
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/1331/merge It will be deleted automatically in 30 days. |
| ## Metric name restrictions | ||
| Metric names must comply with OpenTelemetry and [Prometheus limitations](https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels). | ||
| Metric names must comply with OpenTelemetry and [Prometheus limitations](https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels). The character limit is the same limit k6 had before restricting the character set down. |
There was a problem hiding this comment.
I think we can remove this sentence. If someone is new to k6 and reads this, it doesn't really give them any meaningful information and can just make this more confusing. If they are already familiar with k6, they might also not remember the limit.
There was a problem hiding this comment.
I think it is better if it stays - as it explains the reason for the specific limit.
There was a problem hiding this comment.
I think it's letting the reader know there were changes to the character limit, but it doesn't really give any details on why this has changed, unless we add more information. And I feel like that could quickly become irrelevant in the future...
Is this important for users if they're upgrading from previous versions to 0.47? If it is, we could also switch this to a <blockquote mod='attention'>.
There was a problem hiding this comment.
know there were changes to the character limit
There no loonger is a change.
We currently limit to 128, we started giving warning for characters outside of what Otel and Promehtesu support and found out that Otel has a limit of 63, so we added that to the new warning as well.
Now we foud out the 63 limit for Otel is lifted. So the warning got 128 character as the limti - which is also the current error limit.
So in practice the 128 character limit isn't new it is very old, we just didn't end up adding a new one 63 character limti
Changes in code done in grafana/k6#3335